From 590d81c3ca9e2a3c1dd5ba6d48c4cd4249a63e11 Mon Sep 17 00:00:00 2001 From: Felix Schnabel Date: Wed, 6 Jan 2021 02:00:10 +0100 Subject: [PATCH 1/2] Added Keyboard shortcuts with defaults for Clear read status (alt+C) Set read status to read (alt+R) Set read status to skimmed (alt+S) --- CHANGELOG.md | 1 + src/main/java/org/jabref/gui/actions/StandardActions.java | 6 +++--- src/main/java/org/jabref/gui/keyboard/KeyBinding.java | 5 ++++- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9f1436c4c5b..4a8f39263cd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve - We added the extension support and the external application support (For Texshow, Texmaker and LyX) to the flatpak [#7248](https://github.com/JabRef/jabref/pull/7248) - We added some symbols and keybindings to the context menu in the entry editor. [#7268](https://github.com/JabRef/jabref/pull/7268) +- We added keybindings for setting and clearing the read status. [#7264](https://github.com/JabRef/jabref/issues/7264) ### Changed diff --git a/src/main/java/org/jabref/gui/actions/StandardActions.java b/src/main/java/org/jabref/gui/actions/StandardActions.java index 1bd099016f4..70ae5642647 100644 --- a/src/main/java/org/jabref/gui/actions/StandardActions.java +++ b/src/main/java/org/jabref/gui/actions/StandardActions.java @@ -52,9 +52,9 @@ public enum StandardActions implements Action { PRINTED(Localization.lang("Printed"), IconTheme.JabRefIcons.PRINTED), TOGGLE_PRINTED(Localization.lang("Toggle print status"), IconTheme.JabRefIcons.PRINTED), READ_STATUS(Localization.lang("Read status"), IconTheme.JabRefIcons.READ_STATUS), - CLEAR_READ_STATUS(Localization.lang("Clear read status")), - READ(Localization.lang("Set read status to read"), IconTheme.JabRefIcons.READ_STATUS_READ), - SKIMMED(Localization.lang("Set read status to skimmed"), IconTheme.JabRefIcons.READ_STATUS_SKIMMED), + CLEAR_READ_STATUS(Localization.lang("Clear read status"), KeyBinding.CLEAR_READ_STATUS), + READ(Localization.lang("Set read status to read"), IconTheme.JabRefIcons.READ_STATUS_READ, KeyBinding.READ), + SKIMMED(Localization.lang("Set read status to skimmed"), IconTheme.JabRefIcons.READ_STATUS_SKIMMED, KeyBinding.SKIMMED), RELEVANCE(Localization.lang("Relevance"), IconTheme.JabRefIcons.RELEVANCE), RELEVANT(Localization.lang("Toggle relevance"), IconTheme.JabRefIcons.RELEVANCE), NEW_LIBRARY(Localization.lang("New library"), IconTheme.JabRefIcons.NEW), diff --git a/src/main/java/org/jabref/gui/keyboard/KeyBinding.java b/src/main/java/org/jabref/gui/keyboard/KeyBinding.java index 4c3363c9c6e..ded1e80ac2f 100644 --- a/src/main/java/org/jabref/gui/keyboard/KeyBinding.java +++ b/src/main/java/org/jabref/gui/keyboard/KeyBinding.java @@ -105,7 +105,10 @@ public enum KeyBinding { UNDO("Undo", Localization.lang("Undo"), "ctrl+Z", KeyBindingCategory.EDIT), WEB_SEARCH("Web search", Localization.lang("Web search"), "alt+4", KeyBindingCategory.SEARCH), WRITE_XMP("Write XMP", Localization.lang("Write XMP"), "F6", KeyBindingCategory.TOOLS), - CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE", KeyBindingCategory.SEARCH); + CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE", KeyBindingCategory.SEARCH), + CLEAR_READ_STATUS("Clear read status", Localization.lang("Clear read status"), "alt+C", KeyBindingCategory.EDIT), + READ("Set read status to read", Localization.lang("Set read status to read"), "alt+R", KeyBindingCategory.EDIT), + SKIMMED("Set read status to skimmed", Localization.lang("Set read status to skimmed"), "alt+S", KeyBindingCategory.EDIT); private final String constant; private final String localization; From 33d2da43c047f660801b7da903881dcfe691b922 Mon Sep 17 00:00:00 2001 From: Felix Schnabel Date: Wed, 6 Jan 2021 22:42:50 +0100 Subject: [PATCH 2/2] removed default keybindings for clearing, reading and skimming read status --- src/main/java/org/jabref/gui/keyboard/KeyBinding.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/jabref/gui/keyboard/KeyBinding.java b/src/main/java/org/jabref/gui/keyboard/KeyBinding.java index ded1e80ac2f..69872015acb 100644 --- a/src/main/java/org/jabref/gui/keyboard/KeyBinding.java +++ b/src/main/java/org/jabref/gui/keyboard/KeyBinding.java @@ -106,9 +106,9 @@ public enum KeyBinding { WEB_SEARCH("Web search", Localization.lang("Web search"), "alt+4", KeyBindingCategory.SEARCH), WRITE_XMP("Write XMP", Localization.lang("Write XMP"), "F6", KeyBindingCategory.TOOLS), CLEAR_SEARCH("Clear search", Localization.lang("Clear search"), "ESCAPE", KeyBindingCategory.SEARCH), - CLEAR_READ_STATUS("Clear read status", Localization.lang("Clear read status"), "alt+C", KeyBindingCategory.EDIT), - READ("Set read status to read", Localization.lang("Set read status to read"), "alt+R", KeyBindingCategory.EDIT), - SKIMMED("Set read status to skimmed", Localization.lang("Set read status to skimmed"), "alt+S", KeyBindingCategory.EDIT); + CLEAR_READ_STATUS("Clear read status", Localization.lang("Clear read status"), "", KeyBindingCategory.EDIT), + READ("Set read status to read", Localization.lang("Set read status to read"), "", KeyBindingCategory.EDIT), + SKIMMED("Set read status to skimmed", Localization.lang("Set read status to skimmed"), "", KeyBindingCategory.EDIT); private final String constant; private final String localization;