Decrease size of distribution

[koppor]

(I did not find the issue. Feel free to link the issue and close this one)

Our installer size decreased. I quickly looked into it and foudn following two files:

Do we really need JabRef.merged.module-....jar?

We also have lib/runtime/lib/modules with 157MB of size. Are the modules doubled here?

[tobiasdiez]

I think the jar files are obsolete (also the ones from the libraries) as they all should be included in the lib/modules file...

[koppor]

The other size info was http://builds.jabref.org/chocoDev/:

[koppor]

Largest difference - as we discussed. Will remove them at #5748

• 
• 
• 

[koppor]

Reading the badass jlink link doc:

The badass-jlink plugin takes a more pragmatic approach by combining all non-modular dependencies into a single jar. This way, only the resulting merged module needs a module descriptor.

I interpret this as that the merged module is required somehow. However, I tried to start the portable zip where this was removed (source: http://builds.jabref.org/change-upload-back-to-script/) and it worked. Strange.

[tobiasdiez]

It's probably related to beryx/badass-jlink-plugin#51. I would recommend to remove these files as part of

jabref/build.gradle

Line 699 in 5ffb1b2

task deleteModsFolder(type: Delete) {

[koppor]

Windows

Linux

Mac

[koppor]

I would assume

• jpackageImage creates the .deb, .msi, .pkg files
• jpackageImage includes the app/mods folder
• deleteModsFolder runs after

Which assumption is wrong?

[tobiasdiez]

The first. jpackageImage creates the so-called application image, which contains everything you need to run JabRef (distribution/JabRef). The installer are created afterwards in jpackageInstaller (or something similar named).

Nonetheless, there appears to be a problem as the mods folder is never deleted, right?

[Siedlerchr]

There is a bug report for jpackage: https://bugs.openjdk.java.net/browse/JDK-8236830

[tobiasdiez]

Guess who reported it 😄

[koppor]

Try quick shot by deleting mods folder. IF not succeed, take out of v5.1.

[koppor]

Idea:

• run gradle jPackage locally
• create .sh locally to test
• code and fix
• copy back script commands to build file
• Alternative: register as gradle task and remove files before archive is created
• Good documentation of jlink https://badass-jlink-plugin.beryx.org/releases/latest/

[koppor]

Should be fixed now.