Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor entry type/custom entry type logic #366

Closed
4 of 7 tasks
stefan-kolb opened this issue Nov 19, 2015 · 4 comments
Closed
4 of 7 tasks

Refactor entry type/custom entry type logic #366

stefan-kolb opened this issue Nov 19, 2015 · 4 comments

Comments

@stefan-kolb
Copy link
Member

stefan-kolb commented Nov 19, 2015

Further work from #352:

  • Primary/SecondaryOptionalFields is only used in BibLatex and this logic should be moved into the GUI code.
  • How to handle OR requirements in the GUI? Currently both are marked as required. Next to each other? Highlight required fields red if empty and green if entry hasAllRequired?
  • Check for duplicate field names in requirements and optionals (use a Set? what about 'author/editor'<->'editor/author')
  • Rework custom entry types and include them in the GUI 'new entry'
  • What about overriding known types? (allowed? rejected? what if natbib uses 'book'? and I just need this custom type for natbib files? What about jurabib?)
  • Add more tests
  • Resetting overridden default entry types does not work, sometimes even crashes
@koppor
Copy link
Member

koppor commented Nov 20, 2015

Regarding "OR": In the doc at "Either/or fields", it is talked about that this should work with a special configuration. At least for custom types.

@stefan-kolb stefan-kolb added the bug Confirmed bugs or reports that are very likely to be bugs label Nov 20, 2015
@stefan-kolb stefan-kolb changed the title Refactor entry type logic Refactor entry type/custom entry type logic Nov 20, 2015
@stefan-kolb stefan-kolb added type: enhancement and removed bug Confirmed bugs or reports that are very likely to be bugs labels Mar 10, 2016
@tobiasdiez
Copy link
Member

Also:

  • Store custom entry types in MetaData class and reuse some of the parsing/writing logic.

@matthiasgeiger
Copy link
Member

matthiasgeiger commented Dec 12, 2016

  • "Rework custom entry types and include them in the GUI 'new entry'" is already included:
    custom-new-entry

  • What about overriding known types? (allowed? rejected? what if natbib uses 'book'? and I just need this custom type for natbib files? What about jurabib?)

    • Already supported: Global redefinition of standard types
    • Will be supported with Improve entrytype customization #2331: distinction between bibtex and biblatex
    • Not possible: Overwrite more specifically
  • Resetting overridden default entry types does not work, sometimes even crashes

@LinusDietz
Copy link
Member

superseded by https://github.com/JabRef/jabref/projects/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants