The Group Panel is not updated when switching between certain libraries

[bernhard-kleine]

JabRef 4.0-beta3
Windows 7 6.1 amd64
Java 1.8.0_131

Steps to reproduce:

1. open Jabref with multiple libraries
2. switch between the libraries
3. the updating of the Group Panel is extremely slow and not always correct-

I have the following screenshots to show that behaviour: when I switch from chapter04.bib to EndokrinologieKunde20170513VS4.0.0.bib and vice versa the group panel is not updated, while switching to FatMetabolism20170608VS4.0.0.bib it is updated and then back to either chapter04.bib or EndokrinologieKunde... it is. Chapter04 has 275 entries, FatMetabolism has 900 and Endokrinologiekunde has 1991 entries

Log File

Paste an excerpt of your log file here

[lenhard]

Refs #2690

[lenhard]

This can be reproduced in the following way:

• Start JabRef with two bib files and the the groups side pane open
• Create a new database
• JabRef will switch to the new database, but the groups side pane will display the tree of the last selected database

If tracked the problem down to this part:

jabref/src/main/java/org/jabref/gui/groups/GroupSidePane.java

Lines 131 to 133 in 6a26798

	synchronized (getTreeLock()) {
	validateTree();
	}

Here the groups side pane should repaint, but the JFXPanel does not necessarily do that. The only way I found (and I tried many ways) to force it was by re-creating the completed pane, i.e. by putting this code into the conditional:

            StackPane root = new StackPane();
            root.getChildren().addAll(new GroupTreeView().getView());
            Scene scene = new Scene(root);
            groupsPane.setScene(scene);

But that leads to an ugly flicker in the UI. Resetting the scene with a newly created instance is the key. Without that, no change happens.

@tobiasdiez How can I force the groupsPane to refresh without having to rebuild all its contents? There has to be some way to do this.

[tobiasdiez]

@lenhard I cannot reproduce the issue with the steps you describe with the latest master. For me, an empty groups tree is displayed for the new database.

Codewise, it (should) work as follows: The statemanager is notified about the new database

jabref/src/main/java/org/jabref/gui/JabRefFrame.java

Lines 616 to 618 in 007a534

	Platform.runLater(() ->
	Globals.stateManager.activeDatabaseProperty().setValue(Optional.of(currentBasePanel.getBibDatabaseContext()))
	);

and propagates the event to the group tree view

jabref/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

Lines 55 to 56 in 007a534

	stateManager.activeDatabaseProperty()
	.addListener((observable, oldValue, newValue) -> onActiveDatabaseChanged(newValue));

There the tree is updated,

jabref/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

Line 121 in 007a534

rootGroup.setValue(newRoot);

which triggers a repaint of the tree due to the binding

jabref/src/main/java/org/jabref/gui/groups/GroupTreeController.java

Lines 99 to 105 in 007a534

	groupTree.rootProperty().bind(
	EasyBind.map(viewModel.rootGroupProperty(),
	group -> new RecursiveTreeItem<>(
	group,
	GroupNodeViewModel::getChildren,
	GroupNodeViewModel::expandedProperty,
	viewModel.filterPredicateProperty())));

[lenhard]

@tobiasdiez Hm, you use Win10, right? if you cannot reproduce this, maybe the problem is related to Win7. Because for me it is no problem to reproduce and I have the same setting as @bernhard-kleine

We might need more help tracking this down from other people that use different settings.

[tobiasdiez]

Yes, I'm on Win10. Can you please verify that

jabref/src/main/java/org/jabref/gui/groups/GroupTreeViewModel.java

Line 113 in 007a534

private void onActiveDatabaseChanged(Optional<BibDatabaseContext> newDatabase) {

is invoked (with the proper empty database as argument), when you create a new database.

[lenhard]

I debugged this and the method is invoked with the empty database. This is the case for BibTeX and biblatex, but unfortunately the group tree doesn't get updated properly.

[stefan-kolb]

Can reproduce exactly as described by Jörg (maybe you need to switch between the bibs a bit):

[tobiasdiez]

This should be fixed in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.