Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state should be immutable #1

Open
davemackintosh opened this issue Oct 3, 2018 · 1 comment
Open

state should be immutable #1

davemackintosh opened this issue Oct 3, 2018 · 1 comment

Comments

@davemackintosh
Copy link

One of the best features of Redux is the state is never actually modified, instead it is cloned and the clone is modified and returned as current state. This allows for the most helpful feature of time travel debugging where actions can be recorded and replayed to create a situation and tests. I may PR if I get time.

@JSchaenzle
Copy link
Owner

Good point. Is your concern just that the state mutations don't happen atomically with the current implementation? With the current implementation, if an ISR were to fire during the cedux_run_x function and that ISR had a handle to the store, it's possible that it would access the store in an intermediary state. Is that what the issue you had in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants