Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update shellspec for Debian 12, Rocky 9 #10682

Merged
merged 11 commits into from
Aug 6, 2024

Conversation

donsizemore
Copy link
Contributor

What this PR does / why we need it:

updates shellspec for Debian 12, Rocky 9

Which issue(s) this PR closes:

Closes #10681

Special notes for your reviewer:

none

Suggestions on how to test this:

none

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

no

Is there a release notes update needed for this change?:

no

Additional documentation:

none

Co-authored-by: Ben Companjen <ben@companjen.name>
@donsizemore
Copy link
Contributor Author

@pdurbin @bencomp @poikilotherm how much do we care about shellspec on Deb12? see https://github.com/uncch-rdmc/dataverse/actions/runs/9941676940

@pdurbin
Copy link
Member

pdurbin commented Jul 15, 2024

Meh, I'm ok with dropping it. We still have Ubuntu.

@bencomp
Copy link
Contributor

bencomp commented Jul 15, 2024

I do not care per se if Debian 12 is supported, unless it is supported for the rest of Dataverse. If the issue is that curl is not installed by default, that may be fixable.

I don't know if removing CentOS 7 from this workflow also means the official end of support for that platform? Then a release note would be useful.

@donsizemore
Copy link
Contributor Author

@bencomp Debian 12 is as supported as any other Linux distribution. It is well known that CentOS 7 reached EOL on June 30 2024. I submitted this PR to update that documentation: #10624

@pdurbin pdurbin added Type: Bug a defect Component: Code Infrastructure formerly "Feature: Code Infrastructure" Size: 0.5 A percentage of a sprint. 0.35 hours labels Aug 5, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, @donsizemore!

@pdurbin pdurbin merged commit ac32b00 into IQSS:develop Aug 6, 2024
3 of 4 checks passed
@pdurbin pdurbin added this to the 6.4 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Code Infrastructure formerly "Feature: Code Infrastructure" Size: 0.5 A percentage of a sprint. 0.35 hours Type: Bug a defect
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Shellspec jobs fail for CentOS 7
3 participants