Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8778 harvester ddi exporter #8786

Closed
wants to merge 5 commits into from

Conversation

lubitchv
Copy link
Contributor

@lubitchv lubitchv commented Jun 8, 2022

What this PR does / why we need it:
It replaces short version of harvester exporter XML with a full version, i.e it adds dataDscr and fileDscr sections.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:
Use dataset with tab files. Run:
curl http:/localhost:8080/oai?metadataPrefix=ddi&verb=GetRecord&identifier=$PERSISTENT_ID
The resulting xml should have dataDscr and fileDscr sections.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Update from IQSS develop
@sekmiller sekmiller self-assigned this Aug 31, 2022
@sekmiller sekmiller removed their assignment Aug 31, 2022
@landreev landreev self-assigned this Sep 8, 2022
@landreev
Copy link
Contributor

landreev commented Sep 8, 2022

Hmmm. This is a pretty big deal of a change. I feel like this should've been discussed some more.
There was some serious rationale behind making this harvestable version of the DDI "light" and not include the data description sections. (If nothing else, if we were to make this "OAI_DDI" format exactly the same as "DDI" - there would be no reason to keep maintaining both!).

@lubitchv
Copy link
Contributor Author

As for discussion in the ticket, oai_ddi format remains with short version. DDI format is made harvastable. The label for DDI format was replaced with DDI_full.

@mreekie mreekie added the bk2211 label Nov 1, 2022
@coveralls
Copy link

Coverage Status

Coverage: 20.04%. Remained the same when pulling 18aa019 on lubitchv:8778-harvester-ddi-exporter into 18372cd on IQSS:develop.

@pdurbin
Copy link
Member

pdurbin commented Jan 4, 2023

@lubitchv hi! Yesterday I merged the latest from develop into this PR (I hope you don't mind!) and now this test is failing:

java.lang.AssertionError: expected:<5> but was:<6>
at edu.harvard.iq.dataverse.api.HarvestingServerIT.testOaiListMetadataFormats(HarvestingServerIT.java:188)

Can you please take a look? Also, @landreev recently added a bunch of tests in the following PR and you're welcome to add additional tests if you like!

@mreekie mreekie removed the bk2211 label Jan 11, 2023
@pdurbin pdurbin added the Size: 10 A percentage of a sprint. 7 hours. label Feb 28, 2024
@pdurbin
Copy link
Member

pdurbin commented Feb 28, 2024

From looking at the code I'm still confused. It sure seems like the existing short format would disappear and replaced by the long format. 🤔

Needs discussion or at least some testing.

@scolapasta
Copy link
Contributor

If you are still interested in this PR, can you please merge and resolve any merge conflicts with the latest from develop? If so, we can prioritize reviewing and QAing the changes. If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest).

@pdurbin
Copy link
Member

pdurbin commented May 23, 2024

If we don’t hear from you by May 22, 2024, we’ll go ahead and close this PR (it can always be reopened after that date, if there is still interest).

Closing.

@pdurbin pdurbin closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 10 A percentage of a sprint. 7 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvester exporter uses short version of XML
7 participants