Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globus: DatasetVersion in dataset level externaltool #7740

Closed
lubitchv opened this issue Mar 30, 2021 · 1 comment · Fixed by #8891
Closed

Globus: DatasetVersion in dataset level externaltool #7740

lubitchv opened this issue Mar 30, 2021 · 1 comment · Fixed by #8891
Labels
NIH OTA: 1.1.1 1 | 1.1.1 | Minimum Viable Product (MVP) for registering metadata in the repository and connectin... pm.GREI-d-1.1.1 NIH, yr1, aim1, task1: MVP for registering metadata in the repository
Milestone

Comments

@lubitchv
Copy link
Contributor

At present dataset level external tool although provides a possibility to have DatasetVersion in manifest json and external tool url, but it always brings the last version of dataset, independently from which version user accesses the tool.
There is a need to provide a proper datasetVersion in external tool, not to confuse the user and give the ability to use information from the proper version.
This, for example, is needed for Globus download tool, such that user can access the files from proper version.

@lubitchv lubitchv changed the title DatasetVersion in dataset level externaltool Globus: DatasetVersion in dataset level externaltool Mar 30, 2021
@pdurbin
Copy link
Member

pdurbin commented Mar 30, 2021

@lubitchv I see what you mean...

if(fileMetadata!=null) { //true for file case
    versionString = fileMetadata.getDatasetVersion().getFriendlyVersionNumber();
} else { //Dataset case - return the latest visible version (unless/until the dataset case allows specifying a version)
    if (getApiToken() != null) {
        versionString = dataset.getLatestVersion().getFriendlyVersionNumber();
    } else {
        versionString = dataset.getLatestVersionForCopy().getFriendlyVersionNumber();
    }
}

... at the dataset level the latest version is always returned. I'm not sure why.

@pdurbin pdurbin added this to the 5.12 milestone Sep 19, 2022
@mreekie mreekie added the NIH OTA: 1.1.1 1 | 1.1.1 | Minimum Viable Product (MVP) for registering metadata in the repository and connectin... label Oct 8, 2022
@mreekie mreekie added the pm.GREI-d-1.1.1 NIH, yr1, aim1, task1: MVP for registering metadata in the repository label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NIH OTA: 1.1.1 1 | 1.1.1 | Minimum Viable Product (MVP) for registering metadata in the repository and connectin... pm.GREI-d-1.1.1 NIH, yr1, aim1, task1: MVP for registering metadata in the repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants