Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PermissionServiceBean Cleanup #4944

Closed
4 tasks done
michbarsinai opened this issue Aug 10, 2018 · 8 comments
Closed
4 tasks done

PermissionServiceBean Cleanup #4944

michbarsinai opened this issue Aug 10, 2018 · 8 comments

Comments

@michbarsinai
Copy link
Member

michbarsinai commented Aug 10, 2018

PermissionServiceBean has many deprecated methods, especially those that calculate permissions without taking IP groups into account (a.k.a "static permissions").
This issue will:

  • Remove the static permission code
  • Update code that uses static permissions to use the dynamic permission code
  • Update the developer guide, so it's easier for developers to understand how to query permissions in Dataverse
  • Perform general cleanup on the bean itself, and the related RoleAssignee area

⚠️ This issue was spun off from #2122.

@djbrooke
Copy link
Contributor

@michbarsinai - I moved this back to Community Dev for now. When you have time, please respond to @oscardssmith's feedback and move it back to code review.

@michbarsinai
Copy link
Member Author

@djbrooke done

@pameyer
Copy link
Contributor

pameyer commented Sep 4, 2018

Took a quick look at 406fb41 after hearing @kcondon and @landreev discussing deployment issues (of course, they were talking about 2122-querying-root-dataverse-contents). No issues building or deploying to docker-aio; but integration tests failed ([ERROR] Tests run: 67, Failures: 24, Errors: 17, Skipped: 0).

@djbrooke
Copy link
Contributor

djbrooke commented Sep 5, 2018

Hi @michbarsinai - I moved this back to Community Dev for now, as there are still a few items to work on. If you have the time to work on this, great! If not, let me know and we can get together some resources on this side.

@djbrooke djbrooke self-assigned this Sep 17, 2018
@djbrooke djbrooke removed their assignment Oct 17, 2018
landreev added a commit that referenced this issue Nov 7, 2018
…bean) that was in the original, "Oscar" branch, but not in the cleanup branch. (#4944)
@pdurbin
Copy link
Member

pdurbin commented Oct 2, 2022

@michbarsinai are you still interested in this?

@michbarsinai
Copy link
Member Author

Not in any effective way, I'm afraid. Plus my knowledge is probably outdated on this by now. Happy to consult anyone implementing this, though.

@pdurbin
Copy link
Member

pdurbin commented Oct 3, 2022

@michbarsinai no worries, we'll cook up a fresh issue whenever you want one. Closing! And yes let's consult about something! We miss you! ❤️

@pdurbin pdurbin closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2022
@michbarsinai
Copy link
Member Author

I Miss you too, good people!❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants