CamelCase notation for PostgreSQL function name might cause confusion.

[lobbikerivm]

dataverse/doc/sphinx-guides/source/_static/util/createsequence.sql

Line 25 in fbb215a

CREATE OR REPLACE FUNCTION generateIdentifierFromStoredProcedure()

The actual function created by running this SQL statement is generateidentifierfromstoredprocedure(), without the CamelCase Capitals. If someone would for example manualy create a function with the CamelCase name it will not work, because PostgreSQL will add "" around the function name.

By the way, I used this functionality to get a PID with a random UUID4, by using the function like this:

CREATE OR REPLACE FUNCTION generateidentifierfromstoredprocedure()
RETURNS varchar AS $$
DECLARE
identifier varchar;
BEGIN
identifier := (select gen_random_uuid())::varchar;
RETURN identifier;
END;
$$ LANGUAGE plpgsql IMMUTABLE;

which works nicely :)!

great job on the multiple PID providers!

Stefan

[pdurbin]

Interesting. It sounds like small amount of value we get in readability from the camelCase version don't justify the potential confusion you're pointing out. I don't have any objection to making it all lower case.