IQSS/10711 Cvoc updates #10712
Merged
IQSS/10711 Cvoc updates #10712
+58
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
added
Size: 3
|
Thanks for the mention, we will check if everything is compatible :) |
|
For information, I've run a few tests using the Ontoportal CVOC in addition to ROR and ORCID. I didn't notice any problems editing or displaying keywords. If needed, I can supply the configuration file used, which will need to be adapted to the metadata schemas (TSV file). |
cmbz
added
FY25 Sprint 6
Merged
pdurbin
approved these changes
Sep 24, 2024
|
Regardless of the comment in the external-vocab PR 22, I think I'm ready to merge this PR. |
|
I believe it's all working. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Together with #22, this PR is needed to deploy ORCID/ROR scripts in the author field.
Which issue(s) this PR closes:
Closes #10711
Special notes for your reviewer: @DS-INRA @luddaniel - I think this maintains compatibility with your changes, but it would be good to verify these don't break anything for you.
I also just included an a11y fix for the labels - basically a bug that I noticed in trying to check accessibility for the author/creator field.
Suggestions on how to test this: The simplest test is probably to deploy the updated ORCID/ROR scripts and this PR together and assure that they work together on the author field. (This PR is required for things to work and for the db to get the right values, but the scripts are mostly responsible for the exact look&feel.) Turning the scripts off (by deleting the :CVocConf setting) should show author name/idtype/id correctly set for ORCIDs and with ROR identifiers (vs org names) in the affiliation field. Leaving :CVocConf configured but disabling the scripts (e.g. by adding a typo in the scripts or changing the URLs for them in the CVocConf to be incorrect/give 404s) would let you see the DOM structure and confirm, for example, that the idType field is marked with a data-cvoc-managedfield attribute).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: