Options page and settings #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- INN\PymShortcode is now INN\PymEmbeds - Adds settings page - addresses #32 - helper function INN\PymEmbeds\Settings\option_group() to get the option group name - helper function INN\PymEmbeds\Settings\option_key() to get the option_key for wp_options - helper function INN\PymEmbeds\Settings\settings_section() to get the settings section ID for the settings page - helper function INN\PymEmbeds\Settings\settings_page() to get the settings page ID - option default_pymsrc to change away from that provided by pym_pymsrc_local_url(), which is run through wp_http_validate_url to address #8 (comment) - option override_pymsrc to force use of default_pymsrc in embed output, addressing #8
…verride setting, for #32
…w to test your site for the upgrade checkbox.
benlk
added a commit
that referenced
this pull request
Sep 21, 2018
benlk
added a commit
that referenced
this pull request
Sep 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The next release of the plugin will be 1.3.2.1.
manage_optionscapability, with the following options:Pym.js. This is to make the process of building new interactives easier.readme.txt, since we're now using PHP namespaces for some code.pymjs, known as the pymsrc URL, is now passed through wp_http_validate_url. PR #45 for issue #8.pym.jsis no longer output bythe_content(), instead being output duringwp_footerby an action dedicated to the task. If different shortcodes and/or blocks on the page specify different source URLs for Pym.js, all are output (after removing duplicates), but a message is logged in the browser console. IfWP_DEBUGis set, this message is also logged to the server log, with the post ID specified. PR #34 for issues #33 and #35. See https://github.com/INN/pym-shortcode/tree/master/docs#ive-set-a-different-pymsrc-option-but-now-im-seeing-a-message-in-the-consoledocs/updating-pym.mdbecomesdocs/maintainer-notes.mdTo do: