fix(doc): add missing doc for mock consumer #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
stale
dnwe
force-pushed
the
hsweif/add-missing-content-to-ExpectConsumePartition-comment
branch
from
459b53e
to
85b96a3
Compare
dnwe
force-pushed
the
hsweif/add-missing-content-to-ExpectConsumePartition-comment
branch
from
85b96a3
to
6ff49a0
Compare
dnwe
force-pushed
the
hsweif/add-missing-content-to-ExpectConsumePartition-comment
branch
from
6ff49a0
to
2a49dcb
Compare
The mock SetTopicMetadata entry stopped mid sentence, add remaining details. Fixes: IBM#2374 Signed-off-by: hsweif <alex93179@gmail.com>
dnwe
force-pushed
the
hsweif/add-missing-content-to-ExpectConsumePartition-comment
branch
from
2a49dcb
to
9282d75
Compare
dnwe
changed the title
dnwe
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add the missing comments mentioned by #2374 though I'm not the original author. This PR only contains comment changes. Please help check if the change explains the function as desired. Thanks a lot!