Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): track consumer records lag #2319

Closed
wants to merge 1 commit into from

Conversation

tinaselenge
Copy link

No description provided.

@tinaselenge
Copy link
Author

@dnwe would you mind reviewing the PR please? I fixed the cla failure and lint errors it was reporting.

Comment on lines +190 to +196
if len(b.RecordsSet) > 0 {
logEndOffset := *b.LastRecordsBatchOffset - 1
partitionLag := logEndOffset - b.RecordsSet[len(b.RecordsSet)-1].RecordBatch.LastOffset()
if lagMetric != nil {
lagMetric.Update(partitionLag)
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to pull the lagMetric != nil check up so we avoid doing working out for nothing. That is:

Suggested change
if len(b.RecordsSet) > 0 {
logEndOffset := *b.LastRecordsBatchOffset - 1
partitionLag := logEndOffset - b.RecordsSet[len(b.RecordsSet)-1].RecordBatch.LastOffset()
if lagMetric != nil {
lagMetric.Update(partitionLag)
}
}
if lagMetric != nil && len(b.RecordsSet) > 0 {
logEndOffset := *b.LastRecordsBatchOffset - 1
partitionLag := logEndOffset - b.RecordsSet[len(b.RecordsSet)-1].RecordBatch.LastOffset()
lagMetric.Update(partitionLag)
}

@github-actions
Copy link

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur.
If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

@github-actions github-actions bot added the stale Issues and pull requests without any recent activity label Oct 27, 2023
@github-actions github-actions bot closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issues and pull requests without any recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants