Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add private method to Client interface to prevent implementation #1785

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

justin-chen
Copy link
Contributor

Related: #1781 (comment)

#1781 added an interface method for Client.

Adding interface methods will break backwards compatibility if there's anyone implementing it.This PR adds a private() method to prevent implementation,

@justin-chen justin-chen marked this pull request as ready for review August 19, 2020 16:19
@justin-chen justin-chen requested a review from bai as a code owner August 19, 2020 16:19
@d1egoaz d1egoaz requested review from dnwe and varun06 August 19, 2020 22:02
Copy link
Contributor

@varun06 varun06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the simple and easy way to fix. LGTM

@dnwe dnwe merged commit 84360ef into master Sep 24, 2020
@dnwe dnwe deleted the client-interface-private branch September 24, 2020 12:37
@nayeemzen
Copy link

Breaking mocks for us too google-cloud-go has a package that provides an adapter and interfaces to workaround the problem (feels non-ideal imo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants