From eb67bde0ff5273995c03017166eec2f9d2d2516d Mon Sep 17 00:00:00 2001 From: Tomas Pilar Date: Tue, 22 Aug 2023 08:31:04 +0200 Subject: [PATCH] fix(shebang): avoid node arguments (#21) Signed-off-by: Tomas Pilar Co-authored-by: Tomas Pilar --- .eslintrc.yml | 33 ++++++++++++++++----------------- .github/workflows/node.js.yml | 18 +++++++++++++++++- src/cli.js | 2 +- src/middleware/client.js | 1 - src/utils/version.js | 4 +++- 5 files changed, 37 insertions(+), 21 deletions(-) diff --git a/.eslintrc.yml b/.eslintrc.yml index 59f2fc4..213e622 100644 --- a/.eslintrc.yml +++ b/.eslintrc.yml @@ -1,17 +1,16 @@ - env: - node: true - es2022: true - extends: - - "eslint:recommended" - - "plugin:import/recommended" - - "prettier" - plugins: - - import - parserOptions: - ecmaVersion: "latest" - sourceType: "module" - ignorePatterns: ["src/utils/version.js"] - rules: - "import/order": - - error - - newlines-between: always \ No newline at end of file +env: + node: true + es2022: true +extends: + - "eslint:recommended" + - "plugin:import/recommended" + - "prettier" +plugins: + - import +parserOptions: + ecmaVersion: "latest" + sourceType: "module" +rules: + "import/order": + - error + - newlines-between: always diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 8818837..985a383 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -13,7 +13,6 @@ jobs: strategy: matrix: node-version: [16.x, 18.x, 20.x] - # See supported Node.js release schedule at https://nodejs.org/en/about/releases/ steps: - uses: actions/checkout@v3 @@ -24,3 +23,20 @@ jobs: cache: "yarn" - run: yarn --frozen-lockfile - run: yarn lint + healthcheck: + runs-on: ubuntu-latest + + strategy: + matrix: + node-version: [16.x, 18.x, 20.x] + + steps: + - uses: actions/checkout@v3 + - name: Use Node.js ${{ matrix.node-version }} + uses: actions/setup-node@v3 + with: + node-version: ${{ matrix.node-version }} + cache: "yarn" + - run: yarn --frozen-lockfile + - run: npm install -g . + - run: genai --version diff --git a/src/cli.js b/src/cli.js index 6b1f63c..0f69891 100755 --- a/src/cli.js +++ b/src/cli.js @@ -1,4 +1,4 @@ -#!/usr/bin/env node --no-warnings +#!/usr/bin/env node import { parser } from "./parser.js"; import { isUsageError } from "./errors.js"; diff --git a/src/middleware/client.js b/src/middleware/client.js index 6aa3c65..4b8fc21 100644 --- a/src/middleware/client.js +++ b/src/middleware/client.js @@ -1,6 +1,5 @@ import { Client } from "@ibm-generative-ai/node-sdk"; -// eslint-disable-next-line import/namespace import { version } from "../utils/version.js"; export const clientMiddleware = (args) => { diff --git a/src/utils/version.js b/src/utils/version.js index c7e56c9..37b59fb 100644 --- a/src/utils/version.js +++ b/src/utils/version.js @@ -1,3 +1,5 @@ -import pkg from "../../package.json" assert { type: "json" }; +import { readFile } from 'node:fs/promises'; + +const pkg = JSON.parse(await readFile(new URL('../../package.json', import.meta.url))); export const version = pkg.version;