Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification in the simple_transform_pipeline.md file #163

Closed
2 tasks done
shahrokhDaijavad opened this issue May 21, 2024 · 3 comments
Closed
2 tasks done

Clarification in the simple_transform_pipeline.md file #163

shahrokhDaijavad opened this issue May 21, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request fixed Marks an issues as fixed in the dev branch

Comments

@shahrokhDaijavad
Copy link
Member

shahrokhDaijavad commented May 21, 2024

Search before asking

  • I searched the issues and found no similar issues.

Component

KFP workflows

Feature

I think many first-time users of kfp will start from the simple_transform_pipeline.md file, not having read the kind readme file, in which manual installation of software like helm and kind is mentioned. So, when they get to the preparing kind cluster in this file, they think make setup would install pre-req software too. I suggest adding a link in the simple_transform_pipeline.md file that would take the user to the kind readme file, like this:

Assuming you have pre-installed the software components specified here (the link to the kind readme file), you can create a Kind cluster with all required software installed using the following command: make setup

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!
@shahrokhDaijavad shahrokhDaijavad added the enhancement New feature or request label May 21, 2024
@shahrokhDaijavad
Copy link
Member Author

@roytman If you agree with this, I will make the change and submit a PR.

@roytman
Copy link
Member

roytman commented May 22, 2024

@shahrokhDaijavad I want to reorganize the KFP documentation, and I can include the issue fix in it. I just did not have time. If you want to change it separately, I'm OK with it, but maybe please wait for a day or two.

@shahrokhDaijavad
Copy link
Member Author

OK, @roytman . Thanks. I won't change and wait until you reorganize the KFP documentation.

@roytman roytman added fixed Marks an issues as fixed in the dev branch labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed Marks an issues as fixed in the dev branch
Projects
None yet
Development

No branches or pull requests

2 participants