Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS: Pointer Lock API #252

Closed
shaunlebron opened this issue Dec 7, 2022 · 2 comments · Fixed by #253
Closed

macOS: Pointer Lock API #252

shaunlebron opened this issue Dec 7, 2022 · 2 comments · Fixed by #253

Comments

@shaunlebron
Copy link
Collaborator

shaunlebron commented Dec 7, 2022 •
edited
Loading

This helps prevent accidentally exiting the view when tracking touch points in #249.

Web:

Chromium:

macOS:
@tonsky
Copy link
Collaborator

tonsky commented Dec 8, 2022

Will you make a PR?

@shaunlebron shaunlebron mentioned this issue Dec 8, 2022
Merged
@shaunlebron
Copy link
Collaborator Author

shaunlebron commented Dec 8, 2022 •
edited
Loading

PR is up. But I have to do some more digging to see how chromium adds the movementX and movementY properties to the mouse move event when pointer is locked.

edit: chromium just uses the deltaX and deltaY properties from the NSEvent

edit2: done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

macOS: lock mouse cursor, and add ⌘U to test in dashboard HumbleUI/JWM
2 participants
@shaunlebron @tonsky