Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default wine prefixes folder can be left empty #2556

Open
arielj opened this issue Mar 18, 2023 · 0 comments · May be fixed by #3948
Open

Default wine prefixes folder can be left empty #2556

arielj opened this issue Mar 18, 2023 · 0 comments · May be fixed by #3948
Labels
good first issue Good for newcomers.

Comments

@arielj
Copy link
Collaborator

arielj commented Mar 18, 2023

Describe the bug

When in the General settings, the Set Folder for new Wine Prefixes setting can be left blank, leading to problems installing games.

This is a problem because a user may delete it by mistake and we run no validations and no fallback.

Add logs

This is the log deleting the path:

(15:24:04) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/Heroi"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/Hero"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/Her"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/He"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/H"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Games"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Game"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Gam"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/Ga"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/G"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ariel"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/arie"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ari"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/ar"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/a"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/home"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/hom"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/ho"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/h"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to "/"
(15:24:05) INFO:    [Backend]:          Heroic: Setting defaultInstallPath to ""

Steps to reproduce

  1. Go to Settings
  2. Leave the Set Folder for new Wine Prefixes option completely empty
  3. Try to install a game (the installation folder will by just /theGame which is most likely invalid for installation)

Expected behavior

We should warn the user that they left an empty value there and what the default original value was, so they can leave it empty if they know what they are doing or revert it back to the original it if was a mistake.

Screenshots

No response

Heroic Version

Latest Stable

System Information

not relevant

Additional information

No response
@arielj arielj added the good first issue Good for newcomers. label Feb 13, 2024
@pt8o pt8o linked a pull request Aug 12, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

warn when WinePrefixesBasePath is empty pt8o/HeroicGamesLauncher
1 participant
@arielj