Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: GrapesJS export functionality and 'View Code' functionality and the Canvas not operating in a similar manner with regards to hex colors. #3883

Closed
2 tasks done
akhalid-dev opened this issue Oct 21, 2021 · 0 comments

Comments

@akhalid-dev
Copy link

GrapesJS version

  • I confirm to use the latest version of GrapesJS

What browser are you using?

Chrome v91

Reproducible demo link

https://grapesjs.com/demo.html

Describe the bug

How to reproduce the bug?

  1. Headover to the website: https://grapesjs.com/demo.html.
  2. Clear the canvas for a simpler demonstration.
  3. Drop in a text element from the 'Blocks' section.
  4. Select the dropped in text element, and select 'Style Manager', expand 'Typography' section.
  5. Paste the Hex Value: '8ceb34'. This will update the text color to green in the GrapesJS canvas.
  6. However, when we view generated CSS, or export as zip, the missing '#' sign will be missing and the color won't be applied.

image

What is the expected behavior?
Either, the color shouldn't be updated in the canvas if the '#' is missing, giving the user a false impression that the color is being applied or the '#' should also be added to the Export to zip, or View Code capability.

What is the current behavior?
Current behavior is that the color applies in the GrapesJS canvas, giving the user the False impression that it works, but upon export or viewing Code, it is not generating proper CSS.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@akhalid-dev akhalid-dev changed the title BUG: GrapesJS BUG: GrapesJS export functionality and 'View Code' functionality and the Canvas not operating in a similar manner with regards to hex colors. Oct 21, 2021
@artf artf closed this as completed in 29ff3a4 Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants