Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated readme #906

Merged
merged 1 commit into from
Dec 9, 2019
Merged

updated readme #906

merged 1 commit into from
Dec 9, 2019

Conversation

Pweetoo
Copy link
Contributor

@Pweetoo Pweetoo commented Dec 9, 2019

Added missing argument.

Description

Added missing argument -n for echo command, which corrects wrong base64 string being generated for config.json file. That resulted in authentication error when pushing image to dockerhub.

Added argument -n for echo command.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Pweetoo
Copy link
Contributor Author

Pweetoo commented Dec 9, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tejal29 tejal29 merged commit 6326515 into GoogleContainerTools:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants