Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure paths are absolute before matching files to wildcard sources #330

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Make sure paths are absolute before matching files to wildcard sources #330

merged 1 commit into from
Aug 31, 2018

Commits on Aug 31, 2018

  1. Make sure paths are absolute before matching files to wildcard sources 

    The bug in GoogleContainerTools#329 occurred because of a bug in matchSources, where the
filepath wasn't absolute, so the source "/kaniko-bug/*" wasn't being
matched to the file "kaniko-bug/test-file"

To fix this, I added logic for making filepaths absolute and added to
the unit test for the function to test that it works.
    Priya Wadhwa committed Aug 31, 2018
    Configuration menu
    Copy the full SHA
    1513295 View commit details
    Browse the repository at this point in the history