add /path possible in registry maps and/or mirror #3048
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlec1
reviewed
Mar 6, 2024
pkg/image/remote/remote.go
Outdated
| // this fix automatically add library or the custom path on registry map. | ||
| func normalizeReference(ref name.Reference, image string, custompath string) (name.Reference, error) { | ||
| if custompath == "" { | ||
| custompath = "libary" |
There was a problem hiding this comment.
Sorry, I am not a maintainer, but I noticed a typo here: a r is missing in library
There was a problem hiding this comment.
ahh yeah thankyou, fix in the last commit including fix unit test
|
Thanks for the PR here @prima101112 . Can you rebase the PR here from HEAD and re-submit , recently a CI/CD fix was made for test error seen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2471 and #1618 and it should not againts
Description
add the path when we want --registry-map #1618 and #2471
with path in the mirror.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes