Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix readme sample typo #2792

Merged

Conversation

zhangzhiqiangcs
Copy link
Contributor

@zhangzhiqiangcs zhangzhiqiangcs commented Oct 12, 2023

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)

Description
fix readme typo

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@google-cla
Copy link

google-cla bot commented Oct 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Signed-off-by: zhangzhiqiang02 <zhangzhiqiang02@megvii.com>
Copy link
Collaborator

@aaron-prindle aaron-prindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix here @zhangzhiqiangcs! LGTM

@aaron-prindle aaron-prindle changed the title Fix: readme sample typo docs: fix readme sample typo Oct 18, 2023
@aaron-prindle aaron-prindle merged commit aac7360 into GoogleContainerTools:main Oct 18, 2023
9 of 10 checks passed
@zhangzhiqiangcs zhangzhiqiangcs deleted the fix-readme-typo branch October 18, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants