Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove refs to deprecated io/ioutil #2716

Closed
wants to merge 1 commit into from
Closed

chore: remove refs to deprecated io/ioutil #2716

wants to merge 1 commit into from

Conversation

testwill
Copy link
Contributor

Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
@aaron-prindle
Copy link
Collaborator

@testwill thanks for the PR here! We should be able to get this in if you can rebase this and fix the currently failing lint errors:
https://github.com/GoogleContainerTools/kaniko/actions/runs/6033763043/job/16402297012?pr=2716

Gofmt errors in files:
./pkg/util/transport_util.go
diff ./pkg/util/transport_util.go.orig ./pkg/util/transport_util.go
--- ./pkg/util/transport_util.go.orig
+++ ./pkg/util/transport_util.go
@@ -22,8 +22,8 @@
 	"fmt"
 	"strings"
 
-	"os"
 	"net/http"
+	"os"
 
 	"github.com/GoogleContainerTools/kaniko/pkg/config"
 	"github.com/sirupsen/logrus"
FAILED /home/runner/work/kaniko/kaniko/scripts/../hack/gofmt.sh

```pkg/util/transport_util.go:25: File is not goimports-ed (goimports)
"os"
FAILED /home/runner/work/kaniko/kaniko/scripts/../hack/linter.sh
make: *** [Makefile:67: test] Error 1

@aaron-prindle
Copy link
Collaborator

Created #2806 to track this refactor, closing this PR for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants