Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ACR credential helper to enable Azure Workload Identity #2431

Merged

Conversation

SlavaNL
Copy link
Contributor

@SlavaNL SlavaNL commented Mar 15, 2023

Description

Bump the version of ACR Credential helper to support Azure Workload Identity for Kaniko pods

@google-cla
Copy link

google-cla bot commented Mar 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@imjasonh
Copy link
Collaborator

Nice!

Can you also bump the version that gets compiled into the code and executed when cred helpers aren't available?

kaniko/go.mod

Line 18 in fe2413e

github.com/chrismellard/docker-credential-acr-env v0.0.0-20220119192733-fe33c00cee21

@SlavaNL
Copy link
Contributor Author

SlavaNL commented Mar 15, 2023

@imjasonh the version is bumped

@imjasonh
Copy link
Collaborator

Thanks! You'll also need to accept the Google CLA before this can be merged: https://github.com/GoogleContainerTools/kaniko/pull/2431/checks?check_run_id=12027296256

@SlavaNL
Copy link
Contributor Author

SlavaNL commented Mar 16, 2023

@imjasonh Thanks, CLA is signed

@SlavaNL
Copy link
Contributor Author

SlavaNL commented Mar 17, 2023

@imjasonh for the some reasons all tests failed. What happened?

@imjasonh
Copy link
Collaborator

#48 0.424 go: inconsistent vendoring in /src:
#48 0.424 	github.com/chrismellard/docker-credential-acr-env@v0.0.0-20230304212654-82a0ddb27589: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt
#48 0.424 	github.com/chrismellard/docker-credential-acr-env@v0.0.0-20220119192733-fe33c00cee21: is marked as explicit in vendor/modules.txt, but not explicitly required in go.mod
#48 0.424 
#48 0.424 	To ignore the vendor directory, use -mod=readonly or -mod=mod.
#48 0.424 	To sync the vendor directory, run:
#48 0.424 		go mod vendor

You'll need to run go mod vendor from the root of the repo, and add those files to this PR as well.

@SlavaNL
Copy link
Contributor Author

SlavaNL commented Mar 20, 2023

@imjasonh Done

@SlavaNL
Copy link
Contributor Author

SlavaNL commented Mar 22, 2023

@imjasonh resolved merge conflicts

@imjasonh imjasonh merged commit 86a73c5 into GoogleContainerTools:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants