Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Azure credHelpers docs #2109

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

n3011
Copy link
Contributor

@n3011 n3011 commented May 27, 2022

Update docs related to this issue: #2006

Description

This does not work: "credHelpers":{"xxx.azurecr.io":"acr"}
This works: "credHelpers":{"xxx.azurecr.io":"acr-env"}

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Updated docs string for Azure ACR registry issue.

Copy link
Collaborator

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@imjasonh imjasonh merged commit 1c0e5a0 into GoogleContainerTools:main May 27, 2022
@n3011 n3011 deleted the patch-1 branch May 28, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants