proc: detect kubernetes runtime by mounts #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix GoogleContainerTools#1936 Kubernetes was not being detected by files not by /proc/?/cgroup contents. Now it detects the kubernetes runtime if any of those conditions are met: * /var/run/secrets/kubernetes.io/serviceaccount exists * /proc/mounts has the mount for "/" with fs type "overlay"
imjasonh
approved these changes
Apr 18, 2022
Closed
chuangw6
added a commit
that referenced
this pull request
Jun 1, 2022
Highlights - Installed binaries are missing from image [#2049](#2049) - proc: detect kubernetes runtime by mounts [#2054](#2054) - Fixes #2046: make target stage lookup case insensitive [#2047](#2047) - fix: Refactor LayersMap to correct old strange code behavior [#2066](#2066) - Fix missing setuid flags on COPY --from=build operation [#2089](#2089) - Fixes #2046: make target stage lookup case insensitive [#2047](#2047) - Add GitLab CI credentials helper [#2040]((#2040)) - and a number of dependency bumps
chuangw6
added a commit
that referenced
this pull request
Jun 1, 2022
Highlights - Installed binaries are missing from image #2049 - proc: detect kubernetes runtime by mounts #2054 - Fixes #2046: make target stage lookup case insensitive #2047 - Fix: Refactor LayersMap to correct old strange code behavior #2066 - Fix missing setuid flags on COPY --from=build operation #2089 - Fixes #2046: make target stage lookup case insensitive #2047 - Add GitLab CI credentials helper #2040 - And a number of dependency bumps
chuangw6
added a commit
that referenced
this pull request
Aug 9, 2022
Highlights - Installed binaries are missing from image #2049 - proc: detect kubernetes runtime by mounts #2054 - Fixes #2046: make target stage lookup case insensitive #2047 - Fix: Refactor LayersMap to correct old strange code behavior #2066 - Fix missing setuid flags on COPY --from=build operation #2089 - Fixes #2046: make target stage lookup case insensitive #2047 - Add GitLab CI credentials helper #2040 - And a number of dependency bumps
chuangw6
added a commit
that referenced
this pull request
Aug 10, 2022
Highlights - Installed binaries are missing from image #2049 - proc: detect kubernetes runtime by mounts #2054 - Fixes #2046: make target stage lookup case insensitive #2047 - Fix: Refactor LayersMap to correct old strange code behavior #2066 - Fix missing setuid flags on COPY --from=build operation #2089 - Fixes #2046: make target stage lookup case insensitive #2047 - Add GitLab CI credentials helper #2040 - And a number of dependency bumps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes was not being detected by files not by /proc/?/cgroup
contents. Now it detects the kubernetes runtime if any of those
conditions are met:
Fixes #1936
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes
Release Notes