README.md: Update docs on building for AWS ECR #2020
Conversation
- Kaniko v.1.8.0 does not require additional cred helper logic for ECR, as it discovers ECR repositories automatically and acts accordingly. Thus removed from the documentation. - Add details on using IAM role based authentication for pushing to ECR. Fixes GoogleContainerTools#780 Fixes GoogleContainerTools#1455 Signed-off-by: Jasper Orschulko <Jasper.Orschulko@iris-sensing.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
|
CLA signed. |
|
Just to confirm, you've tested this in your own EC2 instance pushing to ECR correct? This looks great I just want to make double sure it's all true 😄 |
I've tested this on EKS with worker nodes running on EC2 instances and pushing to ECR 👍 |
|
What I haven't tested is credential based access but I see no reason why this should not work 😅 |
|
Looks good to me then! Looks like it's still complaining about the CLA though 🤔 |
had to request a rescan :) |
as it discovers ECR repositories automatically and acts accordingly.
Thus removed from the documentation.
Fixes #780
Fixes #1455
Signed-off-by: Jasper Orschulko Jasper.Orschulko@iris-sensing.com