Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/docker/docker to latest release #1866

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

imjasonh
Copy link
Collaborator

@imjasonh imjasonh commented Dec 30, 2021

Description

go get -u github.com/docker/docker
go mod tidy
go mod vendor

...fix some build breakages...
...remove replace directives...
...add some new replace directives...
...fix some build breakages...
...fix some unit test breakages...

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Update dependency on github.com/docker/docker to v20.10.12

@imjasonh
Copy link
Collaborator Author

Please don't merge this until we have CI back in place, I'm not sure this passes.

@imjasonh imjasonh marked this pull request as draft January 14, 2022 18:28
fix build breakages
fix unit test
Trying to see whether am-i-in-a-container checks are broken for integration tests...
@imjasonh imjasonh marked this pull request as ready for review January 14, 2022 19:54
@imjasonh
Copy link
Collaborator Author

@priyawadhwa this should be ready for a review now, integration tests pass (🎉!!) and I think the "Build images" checks would have failed by now if something was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants