Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include auth for FetchOptions #1796

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Conversation

ygelfand
Copy link
Contributor

Fixes regression introduced in v1.7.0 referenced #719 (comment) (and potentially earlier issues).

Description

FetchOptions needs auth also for private repos

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Fixes private repo branch checkout

Signed-off-by: ygelfand <yuri@shlitz.com>
@google-cla
Copy link

google-cla bot commented Oct 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no CLA not signed by all commit authors label Oct 21, 2021
@ygelfand
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes CLA signed by all commit authors and removed cla: no CLA not signed by all commit authors labels Oct 21, 2021
@hallvors
Copy link

Is this the fix for #1786 and friends?

@ygelfand
Copy link
Contributor Author

Is this the fix for #1786 and friends?

no this is on the (git) context fetch side, that one looks to be on the image push side.

@imjasonh imjasonh merged commit b3ec974 into GoogleContainerTools:master Dec 23, 2021
gcalmettes pushed a commit to gcalmettes/kaniko that referenced this pull request Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants