Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling: storage #1425

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 14, 2020

Description

Fix the spelling of storage

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Sep 14, 2020
@tstromberg
Copy link
Contributor

This PR only appears to add a new-line?

@jsoref
Copy link
Contributor Author

jsoref commented Sep 14, 2020

No, it renames the file, the new line at end-of-file is github being "helpful" (and it isn't an unreasonable change), this might be easier to read than github's fancy gui:
https://patch-diff.githubusercontent.com/raw/GoogleContainerTools/kaniko/pull/1425.patch

(Renames are in metadata)

@tstromberg
Copy link
Contributor

Thanks, I was completely oblivious to the metadata. Looks good to me!

@tejal29 tejal29 merged commit b482458 into GoogleContainerTools:master Sep 30, 2020
@jsoref jsoref deleted the rename-blob-storage branch October 1, 2020 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants