Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set image platform for any build #1130

Merged
merged 6 commits into from
Mar 25, 2020

Conversation

Vlatombe
Copy link
Contributor

@Vlatombe Vlatombe commented Mar 12, 2020

Fixes #997 .
Downstream of google/go-containerregistry#693 for --reproducible to keep os/arch set.

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- Set image platform (os/arch) for any build

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Mar 12, 2020
@samos123 samos123 requested a review from tejal29 March 17, 2020 18:18
@Vlatombe
Copy link
Contributor Author

Anything holding this?

@tejal29
Copy link
Member

tejal29 commented Mar 24, 2020

Sorry @Vlatombe for the delay. Would you be able to merge this with latest master and i can merge this in for next release.

@Vlatombe
Copy link
Contributor Author

Reverted module update since #1146 picked it up.

@Vlatombe
Copy link
Contributor Author

@tejal29 done.

@tejal29 tejal29 merged commit 1978f1e into GoogleContainerTools:master Mar 25, 2020
@Vlatombe Vlatombe deleted the set_image_platform branch April 21, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kaniko doesn’t set image platform for FROM scratch images
4 participants