Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split travis integration tests #1090

Conversation

cvgw
Copy link
Contributor

@cvgw cvgw commented Feb 29, 2020

Fixes #1089

Description

Split integration tests into three travis jobs and move image building to it's own stage.

TestRun and TestLayers each have their own job while the rest of the integration tests run in a single job

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

@googlebot googlebot added the cla: yes CLA signed by all commit authors label Feb 29, 2020
@cvgw cvgw force-pushed the u/cgwippern/1089-split-integration-tests branch 11 times, most recently from 58a20ed to 3f38983 Compare March 1, 2020 05:18
integration/images.go Outdated Show resolved Hide resolved
Copy link
Contributor

@samos123 samos123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself is good, but seems 2 PRs got mixed together

@cvgw
Copy link
Contributor Author

cvgw commented Mar 2, 2020 via email

Split integration tests into three travis jobs
and move image building to it's own stage.

TestRun and TestLayers each have their own job while the
rest of the integration tests run in a single job
@cvgw cvgw force-pushed the u/cgwippern/1089-split-integration-tests branch from 3f38983 to 101ba22 Compare March 3, 2020 19:52
@cvgw cvgw requested review from samos123 and tejal29 March 3, 2020 19:53
@tejal29 tejal29 merged commit d00c84a into GoogleContainerTools:master Mar 4, 2020
@cvgw cvgw deleted the u/cgwippern/1089-split-integration-tests branch March 4, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes CLA signed by all commit authors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Split integration test into multiple travis jobs
4 participants