Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove refs to deprecated io/ioutil #2806

Closed
aaron-prindle opened this issue Oct 18, 2023 · 4 comments · Fixed by #2867
Closed

refactor: remove refs to deprecated io/ioutil #2806

aaron-prindle opened this issue Oct 18, 2023 · 4 comments · Fixed by #2867
Assignees
@Manish-Giri
Labels
area/internal bugs related to kaniko development workflow good first issue Good for newcomers help wanted Looking for a volunteer! kind/enhancement New feature or request kind/suggestion priority/p3 agreed that this would be good to have, but no one is available at the moment.

Comments

@aaron-prindle
Copy link
Collaborator

Currently kaniko has some references to the deprecated io/ioutil library. These should be replaced w/ io references (eg: s/ io/ioutil /io)

This abandoned PR attempted the fix but had some compilation issues:
#2716
@aaron-prindle aaron-prindle added kind/enhancement New feature or request help wanted Looking for a volunteer! good first issue Good for newcomers priority/p3 agreed that this would be good to have, but no one is available at the moment. area/internal bugs related to kaniko development workflow kind/suggestion labels Oct 18, 2023
@aaron-prindle aaron-prindle mentioned this issue Oct 18, 2023
Closed
4 tasks
@Manish-Giri
Copy link
Contributor

Hi, can I take this up?

@kacperswis kacperswis mentioned this issue Oct 18, 2023
Closed
4 tasks
@Manish-Giri
Copy link
Contributor

Thank you, I'm working on it now.

@Manish-Giri
Copy link
Contributor

Status update - changes are underway, and are being done in this branch in my fork.

@aaron-prindle I got an IDE warning while I was in this file in the vendor folder, about this file being auto-generated and should not be modified -

kaniko/vendor/github.com/aws/aws-sdk-go-v2/service/s3/deserializers.go

Line 25 in caedb08

"io/ioutil"

Wanted to confirm that no changes should be made to the vendor folder, then? Are there any other folders where changes should also not be made?

@Manish-Giri
Copy link
Contributor

@aaron-prindle Any thoughts on this?

@Manish-Giri Manish-Giri mentioned this issue Nov 26, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Manish-Giri Manish-Giri

Labels
area/internal bugs related to kaniko development workflow good first issue Good for newcomers help wanted Looking for a volunteer! kind/enhancement New feature or request kind/suggestion priority/p3 agreed that this would be good to have, but no one is available at the moment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove references to deprecated io/ioutil pkg Manish-Giri/kaniko
2 participants
@aaron-prindle @Manish-Giri