Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to provide login credentials for a registry? #109

Closed
damoon opened this issue Apr 17, 2018 · 3 comments · Fixed by #167
Closed

How to provide login credentials for a registry? #109

damoon opened this issue Apr 17, 2018 · 3 comments · Fixed by #167
Labels
area/documentation For all bugs related to documentation kind/feature-request

Comments

@damoon
Copy link

damoon commented Apr 17, 2018

No description provided.

@damoon damoon changed the title Question: How to provide login credentials for a registry? How to provide login credentials for a registry? Apr 17, 2018
@dlorenc
Copy link
Collaborator

dlorenc commented Apr 17, 2018

We should document this more clearly. Kaniko uses docker credential helpers right now, so anything that gets configured in it's container should work. Right now we only bundle the one for GCR, though.

@carlossg carlossg mentioned this issue Apr 20, 2018
Closed
@carlossg
Copy link
Contributor

I have some work in progress in #129

@carlossg carlossg mentioned this issue Apr 23, 2018
Merged
@dlorenc dlorenc added kind/feature-request area/documentation For all bugs related to documentation labels Apr 27, 2018
@dlorenc
Copy link
Collaborator

dlorenc commented Apr 27, 2018

We should put all the credential helpers we know of into the image, then document how to get the underlying credentials needed in as a k8s secret.

@priyawadhwa priyawadhwa mentioned this issue May 2, 2018
Merged
@debuggy debuggy mentioned this issue Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/documentation For all bugs related to documentation kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add credential helper and documentation for pushing to Amazon ECR priyawadhwa/kaniko
3 participants
@carlossg @damoon @dlorenc