Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball manifest.json has incorrect key capitalization #2430

Closed
ctimmins opened this issue Apr 27, 2020 · 2 comments · Fixed by #2454
Closed

Tarball manifest.json has incorrect key capitalization #2430

ctimmins opened this issue Apr 27, 2020 · 2 comments · Fixed by #2454
Assignees
Milestone

Comments

@ctimmins
Copy link

ctimmins commented Apr 27, 2020

Environment:

  • Jib version: v2.x
  • Build tool: Gradle 5.2.1
  • OS: MacOS 10.15

Description of the issue:
manifest.json inside jib image tarball has incorrect capitalization

Expected behavior:
manifest.json should contain key "RepoTags". instead it contains "repoTags".
Technically it is expected to be "repoTags" according to this test but I have always seen "RepoTags" in manifest

Steps to reproduce:

  1. ./gradlew jibBuildTar
  2. cd <buildDir> && tar -xvf jib-image.tar
  3. manifest.json will have a key repoTags

Notes
source pojo

I think adding @JsonProperty("RepoTags") could fix the issue

@chanseokoh chanseokoh added this to the v2.3.0 milestone Apr 27, 2020
@chanseokoh
Copy link
Member

Thanks for reporting. Not just RepoTags but Config and Labels, I think.

@chanseokoh
Copy link
Member

@ctimmins Jib 2.3.0 is released with this fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants