Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Node@12 to test matrix (remove 11) #274

Merged
merged 1 commit into from
Jul 31, 2019
Merged

feat: add Node@12 to test matrix (remove 11) #274

merged 1 commit into from
Jul 31, 2019

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Jul 31, 2019

I am going to land this post-hoc, after we've already created a PR on all Node.js repos.

@bcoe bcoe added the status: blocked Resolving the issue is dependent on other work. label Jul 31, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2019
@bcoe bcoe merged commit 604c0e1 into master Jul 31, 2019
@busunkim96 busunkim96 deleted the node-12 branch September 9, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@jkwlui jkwlui Awaiting requested review from jkwlui

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. status: blocked Resolving the issue is dependent on other work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcoe @JustinBeckwith @googlebot