Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a project pool to avoid test collisions #1428

Closed
grayside opened this issue Jul 25, 2019 · 2 comments
Closed

Use a project pool to avoid test collisions #1428

grayside opened this issue Jul 25, 2019 · 2 comments

Comments

@grayside
Copy link
Collaborator

The golang and ruby sample repositories use a project pool to provide a dedicated GCP project for every CI run.

Doing this is extremely useful for any tests which consume GCP resources:

  • Avoid excessively management of unique namespacing
  • Avoid spawn of many distinctly named resources and management overhead
  • Avoid cross-test data poisoning (writing data to an accidentally shared resource)
  • Avoid cross-test data noise (log entries for concurrent operations requiring careful filtration)

Obstacles: Based on my understanding of how the gimmeproj mechanism works, this would be done for discrete CI runs. This means it would need to apply on a per sample basis in Node.js unless some more grouping were done at the Kokoro configuration level.

I am raising this because navigation of service name uniqueness for Cloud Run samples has taken a significant amount of time.

Ruby and Golang facilitate this with the gimmeproj tool

@broady

@fhinkel
Copy link
Contributor

fhinkel commented Jul 26, 2019

We're using individual tests for Node.js instead of one group test as it's much easier to see on the dashboard which tests are newly failing. If they're all grouped together, chances are that there's always a red one and nobody notices new failures (speaking from experience 😞 ).

@fhinkel
Copy link
Contributor

fhinkel commented Sep 1, 2019

I think the way for now is to use precise names in tests and clean up test specific resources. Closing this for now. Feel free to re-open if we proceed to work on this.

@fhinkel fhinkel closed this as completed Sep 1, 2019
This was referenced Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants