From 40e8bac4b6c1f7ee0749d7ee3f354560c95d5080 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Fri, 12 May 2017 13:16:25 -0700 Subject: [PATCH 1/5] Changes http test to point to better hosting. --- .../cloud-client/src/test/java/com/example/vision/DetectIT.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java index aeabdc92b21..7c0e6082523 100644 --- a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java +++ b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java @@ -124,7 +124,7 @@ public void testLandmarksGcs() throws Exception { @Test public void testLandmarksUrl() throws Exception { // Act - String[] args = {"landmarks", "https://pbs.twimg.com/media/C4wfMOhVcAAUAgq.jpg"}; + String[] args = {"landmarks", "http://wheresgus.com/landmark.jpg"}; Detect.argsHelper(args, out); // Assert From aeb6891c4329ec562f242cbda699e49ef00f4fc9 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Fri, 12 May 2017 16:03:16 -0700 Subject: [PATCH 2/5] Use Cloud Storage bucket for web URI test --- .../src/test/java/com/example/vision/DetectIT.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java index 7c0e6082523..7885be87763 100644 --- a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java +++ b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java @@ -124,7 +124,9 @@ public void testLandmarksGcs() throws Exception { @Test public void testLandmarksUrl() throws Exception { // Act - String[] args = {"landmarks", "http://wheresgus.com/landmark.jpg"}; + String URI = "https://storage-download.googleapis.com/" + + BUCKET + "/vision/landmark.jpg"; + String[] args = {"landmarks", URI}; Detect.argsHelper(args, out); // Assert From b0a6f514c94e1e3a300bf163053c199db9056f14 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Fri, 12 May 2017 16:05:24 -0700 Subject: [PATCH 3/5] Style nit --- .../src/test/java/com/example/vision/DetectIT.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java index 7885be87763..6315f92363b 100644 --- a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java +++ b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java @@ -124,9 +124,9 @@ public void testLandmarksGcs() throws Exception { @Test public void testLandmarksUrl() throws Exception { // Act - String URI = "https://storage-download.googleapis.com/" + - BUCKET + "/vision/landmark.jpg"; - String[] args = {"landmarks", URI}; + String uri = "https://storage-download.googleapis.com/" + + BUCKET + "/vision/landmark.jpg"; + String[] args = {"landmarks", uri}; Detect.argsHelper(args, out); // Assert From 1c37152698ce38c6b67de47cef1f8deeedf6ba83 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Mon, 15 May 2017 13:23:49 -0700 Subject: [PATCH 4/5] Change test to public GCS bucket. --- .../cloud-client/src/test/java/com/example/vision/DetectIT.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java index 6315f92363b..1c2e1b96f87 100644 --- a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java +++ b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java @@ -125,7 +125,7 @@ public void testLandmarksGcs() throws Exception { public void testLandmarksUrl() throws Exception { // Act String uri = "https://storage-download.googleapis.com/" - + BUCKET + "/vision/landmark.jpg"; + + "cloud-samples-tests" + "/vision/landmark.jpg"; String[] args = {"landmarks", uri}; Detect.argsHelper(args, out); From d62d74ec5756803150761b7cb64eb73a283ce7c8 Mon Sep 17 00:00:00 2001 From: Gus Class Date: Mon, 15 May 2017 13:39:07 -0700 Subject: [PATCH 5/5] Change test to environment variable. --- .../cloud-client/src/test/java/com/example/vision/DetectIT.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java index 1c2e1b96f87..6315f92363b 100644 --- a/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java +++ b/vision/cloud-client/src/test/java/com/example/vision/DetectIT.java @@ -125,7 +125,7 @@ public void testLandmarksGcs() throws Exception { public void testLandmarksUrl() throws Exception { // Act String uri = "https://storage-download.googleapis.com/" - + "cloud-samples-tests" + "/vision/landmark.jpg"; + + BUCKET + "/vision/landmark.jpg"; String[] args = {"landmarks", uri}; Detect.argsHelper(args, out);