fix: support Google OAuth Client credentials without expiration time

[dirkluijk]

Change Description

Small fix for #1097 (cf024eb) to also allow credentials without an expiration time.

I only tested the previous fix with my own application default credentials, but it seems some tokens don't have the expiration time as it can be null.

Checklist

• Make sure to open an issue as a
  bug/issue
  before writing your code! That way we can discuss the change, evaluate
  designs, and agree on the general idea.
• Ensure the tests and linter pass
• Appropriate documentation is updated (if necessary)

Relevant issues:

Additional fix for #1093.

[shubha-rajan]

Looks like these are null pointer exceptions

[dirkluijk]

@shubha-rajan for some reason, I cannot run the unit tests locally (had issues before, but I also remember having them running fine). I also tried ifconfig lo0 alias 127.0.0.2 up several times since I am running on macOS.

Anyway, I fixed the issue from the build.

[shubha-rajan]

nit: can we use an optional here instead of this ternary?

something like:

Optional<Long> expTime = Optional.ofNullable(credential.getExpirationTimeMilliseconds());

AccessToken accessToken = new AccessToken(
          credential.getAccessToken(),
          expTime.isPresent()
              ? new Date(expTime.get())
              : null
          );

[shubha-rajan]

@shubha-rajan for some reason, I cannot run the unit tests locally (had issues before, but I also remember having them running fine). I also tried ifconfig lo0 alias 127.0.0.2 up several times since I am running on macOS.

Anyway, I fixed the issue from the build.

Looks like there are still errors. The fix should just be to add a check before L398 to check whether tokenExpiration is null.

[dirkluijk]

All right, I pushed a fix, let's see.

[shubha-rajan]

All right, I pushed a fix, let's see.

Looks like tests are passing this time. Did you see my note about using an Optional? It might be a nit, but I think it makes the code cleaner.

[dirkluijk]

Ah, I already dragged in jsr305 for nullability, but Optional makes more sense indeed (writing Kotlin for some time already). Will have a look at it.

[dirkluijk]

Applied your feedback! 🤞