fix: add compatibility for GraalVM 22.2.0 #1025

shubha-rajan · 2022-10-28T02:02:46Z

Change Description

Remove references to svm dependency
Upgrade Native Image Maven plugin
Change scope of drivers to compile for native image builds

conventional-commit-lint-gcf · 2022-10-28T02:02:50Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

enocom · 2022-11-02T21:08:58Z

jdbc/mysql-j-8/pom.xml

@@ -164,6 +164,16 @@
        </dependency>
      </dependencies>
    </profile>
+    <profile>
+      <id>native</id>


Should these deps be marked as "provided" so the user can set them?

Marking them as provided was what was causing one of the errors, so here we're overriding the provided scope with a compile scope. This was the error:

Failures (2): JUnit Vintage:JdbcPostgresIamAuthIntegrationTests:pooledConnectionTest MethodSource [className = 'com.google.cloud.sql.postgres.JdbcPostgresIamAuthIntegrationTests', methodName = 'pooledConnectionTest', methodParameterTypes = ''] => org.opentest4j.MultipleFailuresError: Multiple Failures (2 failures) java.lang.RuntimeException: Failed to get driver instance for jdbcUrl=jdbc:postgresql:///proxy_testing java.lang.NullPointerException: <no message> org.junit.vintage.engine.execution.TestRun.getStoredResultOrSuccessful(TestRun.java:200) org.junit.vintage.engine.execution.RunListenerAdapter.fireExecutionFinished(RunListenerAdapter.java:248) org.junit.vintage.engine.execution.RunListenerAdapter.testFinished(RunListenerAdapter.java:214) org.junit.vintage.engine.execution.RunListenerAdapter.testFinished(RunListenerAdapter.java:88) org.junit.runner.notification.SynchronizedRunListener.testFinished(SynchronizedRunListener.java:87) [...] Suppressed: java.lang.RuntimeException: Failed to get driver instance for jdbcUrl=jdbc:postgresql:///proxy_testing com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:114) com.zaxxer.hikari.pool.PoolBase.initializeDataSource(PoolBase.java:331) com.zaxxer.hikari.pool.PoolBase.<init>(PoolBase.java:114) com.zaxxer.hikari.pool.HikariPool.<init>(HikariPool.java:108) com.zaxxer.hikari.HikariDataSource.<init>(HikariDataSource.java:81) [...] Caused by: java.sql.SQLException: No suitable driver java.sql.DriverManager.getDriver(DriverManager.java:298) com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:106) [...] Suppressed: java.lang.NullPointerException com.google.cloud.sql.postgres.JdbcPostgresIamAuthIntegrationTests.dropTableIfPresent(JdbcPostgresIamAuthIntegrationTests.java:111) java.lang.reflect.Method.invoke(Method.java:566) org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) [...] JUnit Vintage:JdbcPostgresIntegrationTests:pooledConnectionTest MethodSource [className = 'com.google.cloud.sql.postgres.JdbcPostgresIntegrationTests', methodName = 'pooledConnectionTest', methodParameterTypes = ''] => org.opentest4j.MultipleFailuresError: Multiple Failures (2 failures) java.lang.RuntimeException: Failed to get driver instance for jdbcUrl=jdbc:postgresql:///proxy_testing java.lang.NullPointerException: <no message> org.junit.vintage.engine.execution.TestRun.getStoredResultOrSuccessful(TestRun.java:200) org.junit.vintage.engine.execution.RunListenerAdapter.fireExecutionFinished(RunListenerAdapter.java:248) org.junit.vintage.engine.execution.RunListenerAdapter.testFinished(RunListenerAdapter.java:214) org.junit.vintage.engine.execution.RunListenerAdapter.testFinished(RunListenerAdapter.java:88) org.junit.runner.notification.SynchronizedRunListener.testFinished(SynchronizedRunListener.java:87) [...] Suppressed: java.lang.RuntimeException: Failed to get driver instance for jdbcUrl=jdbc:postgresql:///proxy_testing com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:114) com.zaxxer.hikari.pool.PoolBase.initializeDataSource(PoolBase.java:331) com.zaxxer.hikari.pool.PoolBase.<init>(PoolBase.java:114) com.zaxxer.hikari.pool.HikariPool.<init>(HikariPool.java:108) com.zaxxer.hikari.HikariDataSource.<init>(HikariDataSource.java:81) [...] Caused by: java.sql.SQLException: No suitable driver java.sql.DriverManager.getDriver(DriverManager.java:298) com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:106) [...] Suppressed: java.lang.NullPointerException com.google.cloud.sql.postgres.JdbcPostgresIntegrationTests.dropTableIfPresent(JdbcPostgresIntegrationTests.java:104) java.lang.reflect.Method.invoke(Method.java:566) org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) [...]

enocom

LGTM.

mpeddada1

@shubha-rajan the use of the svm dependency has been debated for some time and there were some discussions to stop releasing it. For stability in the future releases, it might be better to remove references to it. We have a couple of references here:

cloud-sql-jdbc-socket-factory/core/src/main/java/com/google/cloud/sql/nativeimage/CloudSqlFeature.java

Lines 20 to 21 in 15e01f4

    
           import com.oracle.svm.core.annotate.AutomaticFeature; 
        
           import com.oracle.svm.core.configure.ResourcesRegistry;

.

Here is an example of how AutomaticFeature was replaced in gax: googleapis/gax-java@2229bfe
The use of the ResourceRegistration class can be replaced with using resource-config.json. For example: https://github.com/googleapis/gax-java/pull/1674/files

shubha-rajan · 2022-11-16T21:55:29Z

@shubha-rajan the use of the svm dependency has been debated for some time and there were some discussions to stop releasing it.

I followed the example to remove the svm references here. PTAL

mpeddada1 · 2022-11-15T16:24:25Z

jdbc/mysql-j-8/pom.xml

+        <dependency>
+          <groupId>mysql</groupId>
+          <artifactId>mysql-connector-java</artifactId>
+          <version>8.0.17</version>
+        </dependency>


Ah quick question, what error do we run into if we don't include this dependency? Is it the one you mentioned above?

No it's a different one. "No suitable driver found." I started seeing it after upgrading the maven plugin.

Suppressed: java.lang.RuntimeException: Failed to get driver instance for jdbcUrl=jdbc:postgresql:///proxy_testing com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:114) com.zaxxer.hikari.pool.PoolBase.initializeDataSource(PoolBase.java:331) com.zaxxer.hikari.pool.PoolBase.<init>(PoolBase.java:114) com.zaxxer.hikari.pool.HikariPool.<init>(HikariPool.java:108) com.zaxxer.hikari.HikariDataSource.<init>(HikariDataSource.java:81) [...] Caused by: java.sql.SQLException: No suitable driver java.sql.DriverManager.getDriver(DriverManager.java:298) com.zaxxer.hikari.util.DriverDataSource.<init>(DriverDataSource.java:106) [...] Suppressed: java.lang.NullPointerException com.google.cloud.sql.postgres.JdbcPostgresIamAuthIntegrationTests.dropTableIfPresent(JdbcPostgresIamAuthIntegrationTests.java:111) java.lang.reflect.Method.invoke(Method.java:566) org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) [...]

Interesting, thanks for the stacktrace! I wonder if this dependency is not being included in the classpath generated by the native maven plugin. Optional, but it might also be worth checking if this is a regression introduced by the plugin. There was an issue when we upgraded to 0.9.12 where test-jar dependencies weren't getting recognized: https://github.com/mpeddada1/0.9.12-test-jar so this could be similar.

I think the issues are related. I'll put together a quick repro so we can track this.

unfortunately we still have to upgrade because we get UnsupportedFeatureExceptions otherwise

mpeddada1 · 2022-11-16T22:28:03Z

.../main/resources/META-INF/native-image/com.google.cloud.sql/native-image/resource-config.json

@@ -0,0 +1,11 @@
+{


nit: how about we name this directoryMETA-INF/native-image/com.google.cloud.sql/jdbc-socket-factory-parent/native-image.properties? For more info: https://www.graalvm.org/22.1/reference-manual/native-image/BuildConfiguration/#embedding-a-configuration-file

mpeddada1 · 2022-11-17T02:49:01Z

pom.xml

@@ -72,9 +72,8 @@
  <properties>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <javac.version>9+181-r4173-1</javac.version>
-    <native-image.version>0.9.11</native-image.version>
+    <native-image.version>0.9.16</native-image.version>
    <graal-sdk.version>21.3.4</graal-sdk.version>


This might also need to be updated to 22.2.0.

mpeddada1 · 2022-11-17T03:00:23Z

jdbc/mysql-j-8/pom.xml

+        <dependency>
+          <groupId>mysql</groupId>
+          <artifactId>mysql-connector-java</artifactId>
+          <version>8.0.17</version>
+        </dependency>


Interesting, thanks for the stacktrace! I wonder if this dependency is not being included in the classpath generated by the native maven plugin. Optional, but it might also be worth checking if this is a regression introduced by the plugin. There was an issue when we upgraded to 0.9.12 where test-jar dependencies weren't getting recognized: https://github.com/mpeddada1/0.9.12-test-jar so this could be similar.

mpeddada1

LGTM

shubha-rajan force-pushed the fix-graalvm-build branch 7 times, most recently from 384ebab to 053cac8 Compare November 1, 2022 19:41

shubha-rajan changed the title ~~fix: add exports for native image compilation~~ fix: add compatibility for GraalVM 22.3.0 Nov 1, 2022

shubha-rajan marked this pull request as ready for review November 1, 2022 20:11

shubha-rajan requested review from a team and suztomo November 1, 2022 20:11

enocom reviewed Nov 2, 2022

View reviewed changes

enocom self-requested a review November 2, 2022 21:11

enocom approved these changes Nov 2, 2022

View reviewed changes

shubha-rajan changed the title ~~fix: add compatibility for GraalVM 22.3.0~~ fix: add compatibility for GraalVM 22.2.0 Nov 8, 2022

shubha-rajan requested a review from mpeddada1 November 14, 2022 21:05

mpeddada1 reviewed Nov 15, 2022

View reviewed changes

shubha-rajan force-pushed the fix-graalvm-build branch from 4f6002c to 2bed7ae Compare November 16, 2022 21:08

shubha-rajan requested a review from mpeddada1 November 16, 2022 21:54

mpeddada1 reviewed Nov 16, 2022

View reviewed changes

shubha-rajan added 8 commits November 16, 2022 15:21

add exports for native image compilation

b5f8f52

add export for org.graalvm.util

a52ffe2

enable agent to generate reflect-config file

f5b2af3

add junit-vintage as a dependency to maven surefire

23e790a

update nativeimage version

8efc1b2

remove agent and surefire junit dependency

21494b7

override driver scope in dependencymanagement for native image profile

556567f

unpin graalvm image

a23e3cf

shubha-rajan added 7 commits November 16, 2022 15:21

add driver dependencies to native profile

26c214a

remove references to svm dependency

933f019

formatting

d67da94

remove svm dependency from pom files

2d96cfe

fix resource-config.json

367a605

add missing newlines

f251974

rename native image resource directory

0dae288

shubha-rajan force-pushed the fix-graalvm-build branch from 835daed to 0dae288 Compare November 16, 2022 23:21

shubha-rajan requested a review from mpeddada1 November 16, 2022 23:24

mpeddada1 reviewed Nov 17, 2022

View reviewed changes

mpeddada1 approved these changes Nov 17, 2022

View reviewed changes

shubha-rajan added 4 commits November 17, 2022 10:57

Update pom.xml

2a95158

Merge branch 'main' into fix-graalvm-build

9d9ec6c

Merge branch 'main' into fix-graalvm-build

2ba51bf

leave comment re: drivers in native profile

7782914

shubha-rajan merged commit bd153cd into main Nov 17, 2022

shubha-rajan deleted the fix-graalvm-build branch November 17, 2022 20:50

github-actions bot mentioned this pull request Nov 17, 2022

chore(main): release 1.8.0 #1054

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: add compatibility for GraalVM 22.2.0 #1025

fix: add compatibility for GraalVM 22.2.0 #1025

shubha-rajan commented Oct 28, 2022 •

edited

Loading

conventional-commit-lint-gcf bot commented Oct 28, 2022

enocom Nov 2, 2022

shubha-rajan Nov 2, 2022

enocom left a comment

mpeddada1 left a comment

shubha-rajan commented Nov 16, 2022 •

edited

Loading

mpeddada1 Nov 15, 2022

shubha-rajan Nov 16, 2022

shubha-rajan Nov 16, 2022

mpeddada1 Nov 17, 2022

shubha-rajan Nov 17, 2022

shubha-rajan Nov 17, 2022

mpeddada1 Nov 16, 2022

shubha-rajan Nov 16, 2022

mpeddada1 Nov 17, 2022

mpeddada1 Nov 17, 2022

mpeddada1 left a comment

	import com.oracle.svm.core.annotate.AutomaticFeature;
	import com.oracle.svm.core.configure.ResourcesRegistry;

fix: add compatibility for GraalVM 22.2.0 #1025

fix: add compatibility for GraalVM 22.2.0 #1025

Conversation

shubha-rajan commented Oct 28, 2022 • edited Loading

Change Description

conventional-commit-lint-gcf bot commented Oct 28, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

enocom left a comment

Choose a reason for hiding this comment

mpeddada1 left a comment

Choose a reason for hiding this comment

shubha-rajan commented Nov 16, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mpeddada1 left a comment

Choose a reason for hiding this comment

shubha-rajan commented Oct 28, 2022 •

edited

Loading

shubha-rajan commented Nov 16, 2022 •

edited

Loading