feat: (Blueprint) Allow customization of setup sa key #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegolnasc
requested review from
bharathkkb,
morgante and
ocsig
as code owners
diegolnasc
changed the title
bharathkkb
reviewed
Feb 7, 2022
| @@ -40,6 +40,7 @@ const setupKeyOutputName = "sa_key" | |||
| type TFBlueprintTest struct { | |||
| discovery.BlueprintTestConfig // additional blueprint test configs | |||
| name string // descriptive name for the test | |||
| saKey string // optional setup encoded sa key | |||
There was a problem hiding this comment.
If we are specifying an explicit SA key, I would expect it to be already decoded (i.e not b64 encoded) since thats how you would download/generate it via gcloud. WDYT?
There was a problem hiding this comment.
I agree.
My script was already generating base64 so I ended up skewing it.
diegolnasc
changed the title
morgante
reviewed
Feb 7, 2022
| @@ -205,6 +210,19 @@ func (b *TFBlueprintTest) getTFOutputsAsInputs(o map[string]interface{}) map[str | |||
| return n | |||
| } | |||
|
|
|||
| // loadSetupSAKey activate a gcp encoded sa key | |||
| func (b *TFBlueprintTest) loadSetupSAKey(saKey string, isEncoded bool) { | |||
There was a problem hiding this comment.
Instead of having the isEncoded logic here, I'd just keep it on line 164.
There was a problem hiding this comment.
I thought it would be cleaner in func loadSetupSAKey.
Well, I'm going to delete the func because it will lose the sense of existing just to call gcloud cmd.
morgante
approved these changes
Feb 7, 2022
This was referenced Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make setup sa key more flexible for other tests.