Refactor to centralise controller #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_Breaking Changes_ We are going to end up with multiple controllers and CRDs in this system, so refactoring gameserver code under `pkg`, and moving binaries under `cmd`. This will keep the top level directories clean and understandable no matter how many extra CRDs we add. The `gameserver-controller` image is also now the `agon-controller` image. Upgrade should be a delete the old `gameserver-controller` deployment and install as per normal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
We are going to end up with multiple controllers and CRDs in this system, so refactoring gameserver
code under
pkg, and moving binaries undercmd.This will keep the top level directories clean and understandable no matter how many extra CRDs we add.
The
gameserver-controllerimage is also now theagon-controllerimage.Upgrade should be a delete the old
gameserver-controllerdeployment and install as per normal.