Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency: Portpolicy static=>Static & dynamic=>Dynamic #617

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Consistency: Portpolicy static=>Static & dynamic=>Dynamic #617

merged 2 commits into from
Feb 22, 2019

Conversation

markmandel
Copy link
Member

This has been bothering me for a while. Finally fixed it.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc kind/breaking Breaking change labels Feb 22, 2019
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ae4dcb1d-f696-4e00-98ec-b3d9e58b1626

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Consistency: Portpolicy static=>Static & dynamic=>Dynamic
c55fe5c 
This has been bothering me for a while. Finally fixed it.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9caa6d82-d487-4dcc-be83-96b3d3bc1212

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/617/head:pr_617 && git checkout pr_617
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-c55fe5c

cyriltovena
cyriltovena approved these changes Feb 22, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel added this to the 0.9.0 milestone Feb 22, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 608e2642-bf65-40c6-a6ed-df18a95c8ffc

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/617/head:pr_617 && git checkout pr_617
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-97c5b72

@markmandel markmandel merged commit 210f18e into googleforgames:master Feb 22, 2019
@markmandel markmandel deleted the cleanup/port-policy branch February 22, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/breaking Breaking change kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @cyriltovena