Adding explicit length of git revision in Makefile and E2E Can't Allocate test #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker images which are stored in docker registry currently has format with hash of size 7 for instanse: agones-controller:0.7.0-5e2ad5e So on some platforms this git rev-parse command could results in 8 hex symbols.
|
Build Succeeded 👏 Build Id: a6f2efa5-ec49-4c84-b7ee-ba420f93ce24 The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
reviewed
Dec 7, 2018
There was a problem hiding this comment.
A couple of small things to fixup, but overall looks great 👍
We usually merge our PRs into a single commit for each pull request - not sure if you want to pull the explicit length fix into another PR, or just include it in the comments in the single commit - I don't mind, up to you.
Otherwise, looks pretty good!
test/e2e/fleet_test.go
Outdated
| @@ -318,14 +366,16 @@ func scaleFleet(f *v1alpha1.Fleet, scale int32) (*v1alpha1.Fleet, error) { | |||
| return framework.AgonesClient.StableV1alpha1().Fleets(defaultNs).Patch(f.ObjectMeta.Name, types.JSONPatchType, []byte(patch)) | |||
| } | |||
|
|
|||
| const replicasCount = 3 | |||
There was a problem hiding this comment.
Let's move this up to the top with the rest of the consts - that's the usual go way.
Simple test which checks that we are able to add not more than Replica count of gameservers per one fleet.
aLekSer
force-pushed
the
explicit-git-rev-parse-len
branch
from
e0aea88
to
d3b5846
Compare
|
Build Succeeded 👏 Build Id: 8103374b-c498-4ba1-8350-169a1e4c226a The following development artifacts have been built, and will exist for the next 30 days:
To install this version:
|
markmandel
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output of git rev-parse short command could be different for different environments. For example on my laptop I got 8 chars which leads to errors on deployment to test-cluster using make install.
Namely:
which should be gcr.io/agones-images/agones-controller:0.7.0-5e2ad5e.
Also adding separate test for "Can't allocate on fully sized fleet".