Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make WaitForFleetCondition take up to 5 minutes #377

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Make WaitForFleetCondition take up to 5 minutes #377

merged 1 commit into from
Oct 9, 2018

Conversation

markmandel
Copy link
Member

Should fix flakiness in autoscaler tests.

@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Oct 8, 2018
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ff7edc18-51cb-4080-8a27-706f8d5da25e

Build Logs 
starting build "ff7edc18-51cb-4080-8a27-706f8d5da25e"

FETCHSOURCE
Initialized empty Git repository in /workspace/.git/
From https://source.developers.google.com/p/agones-images/r/agones
 * branch            56adbc7c96ef2ef13ff4a256a4839eae737edbfd -> FETCH_HEAD
HEAD is now at 56adbc7 Make WaitForFleetCondition take up to 5 minutes
BUILD
Starting Step #0
Step #0: Already have image (with digest): ubuntu
Finished Step #0
Starting Step #1
Step #1: Already have image (with digest): gcr.io/cloud-builders/docker
Step #1: Sending build context to Docker daemon  107.5MB

Step #1: Step 1/3 : FROM gcr.io/cloud-builders/docker
Step #1:  ---> 688137911e96
Step #1: Step 2/3 : RUN apt-get install make
Step #1:  ---> Running in 71a9f8132449
Step #1: Reading package lists...
Step #1: Building dependency tree...
Step #1: Reading state information...
Step #1: make is already the newest version (4.1-6).
Step #1: 0 upgraded, 0 newly installed, 0 to remove and 2 not upgraded.
Step #1: Removing intermediate container 71a9f8132449
Step #1:  ---> 97a3537a07d8
Step #1: Step 3/3 : ENTRYPOINT ["/usr/bin/make"]
Step #1:  ---> Running in f705528ac37f
Step #1: Removing intermediate container f705528ac37f
Step #1:  ---> e556abfe5f31
Step #1: Successfully built e556abfe5f31
Step #1: Successfully tagged make-docker:latest
Finished Step #1
Starting Step #2
Step #2: Already have image: make-docker
Step #2: docker pull gcr.io/agones-images/agones-build:add8116b91 && docker tag gcr.io/agones-images/agones-build:add8116b91 agones-build:add8116b91
Step #2: add8116b91: Pulling from agones-images/agones-build
Step #2: cc1a78bfd46b: Pulling fs layer
Step #2: 65ec5fb8fee4: Pulling fs layer
Step #2: f792a8d67267: Pulling fs layer
Step #2: 1d9810dc510f: Pulling fs layer
Step #2: 1857069560bc: Pulling fs layer
Step #2: 78e6ceea88a6: Pulling fs layer
Step #2: 17808c78ea57: Pulling fs layer
Step #2: 8f44844313bf: Pulling fs layer
Step #2: 68ad45c242a0: Pulling fs layer
Step #2: fcf83fd73d90: Pulling fs layer
Step #2: f7e1d363b903: Pulling fs layer
Step #2: db117322f9a6: Pulling fs layer
Step #2: 107df8cebbb8: Pulling fs layer
Step #2: 1cc01a448cf6: Pulling fs layer
Step #2: d21f6d830ee4: Pulling fs layer
Step #2: fc42a3e733c1: Pulling fs layer
Step #2: dc1d9449fa6d: Pulling fs layer
Step #2: 1a868119fc13: Pulling fs layer
Step #2: 9f6036440dbe: Pulling fs layer
Step #2: 781f18f06da3: Pulling fs layer
Step #2: eed24b20f933: Pulling fs layer
Step #2: 796c70780a0c: Pulling fs layer
Step #2: fcf83fd73d90: Waiting
Step #2: 1d9810dc510f: Waiting
Step #2: 1857069560bc: Waiting
Step #2: f7e1d363b903: Waiting
Step #2: dc1d9449fa6d: Waiting
Step #2: db117322f9a6: Waiting
Step #2: 78e6ceea88a6: Waiting
Step #2: 1a868119fc13: Waiting
Step #2: 17808c78ea57: Waiting
Step #2: 107df8cebbb8: Waiting
Step #2: 9f6036440dbe: Waiting
Step #2: 1cc01a448cf6: Waiting
Step #2: 781f18f06da3: Waiting
Step #2: d21f6d830ee4: Waiting
Step #2: fc42a3e733c1: Waiting
Step #2: 8f44844313bf: Waiting
Step #2: eed24b20f933: Waiting
Step #2: 68ad45c242a0: Waiting
Step #2: 796c70780a0c: Waiting
Step #2: cc1a78bfd46b: Verifying Checksum
Step #2: cc1a78bfd46b: Download complete
Step #2: 1d9810dc510f: Verifying Checksum
Step #2: 1d9810dc510f: Download complete
Step #2: 65ec5fb8fee4: Verifying Checksum
Step #2: 65ec5fb8fee4: Download complete
Step #2: 78e6ceea88a6: Verifying Checksum
Step #2: 78e6ceea88a6: Download complete
Step #2: 17808c78ea57: Verifying Checksum
Step #2: 17808c78ea57: Download complete
Step #2: 1857069560bc: Verifying Checksum
Step #2: 1857069560bc: Download complete
Step #2: 68ad45c242a0: Download complete
Step #2: 8f44844313bf: Verifying Checksum
Step #2: 8f44844313bf: Download complete
Step #2: f7e1d363b903: Verifying Checksum
Step #2: f7e1d363b903: Download complete
Step #2: fcf83fd73d90: Verifying Checksum
Step #2: fcf83fd73d90: Download complete
Step #2: db117322f9a6: Verifying Checksum
Step #2: db117322f9a6: Download complete
Step #2: 107df8cebbb8: Verifying Checksum
Step #2: 107df8cebbb8: Download complete
Step #2: 1cc01a448cf6: Verifying Checksum
Step #2: 1cc01a448cf6: Download complete
Step #2: d21f6d830ee4: Verifying Checksum
Step #2: d21f6d830ee4: Download complete
Step #2: dc1d9449fa6d: Verifying Checksum
Step #2: dc1d9449fa6d: Download complete
Step #2: 1a868119fc13: Verifying Checksum
Step #2: 1a868119fc13: Download complete
Step #2: 9f6036440dbe: Download complete
Step #2: 781f18f06da3: Verifying Checksum
Step #2: 781f18f06da3: Download complete
Step #2: eed24b20f933: Download complete
Step #2: 796c70780a0c: Download complete
Step #2: cc1a78bfd46b: Pull complete
Step #2: fc42a3e733c1: Verifying Checksum
Step #2: fc42a3e733c1: Download complete
Step #2: f792a8d67267: Verifying Checksum
Step #2: f792a8d67267: Download complete
Step #2: 65ec5fb8fee4: Pull complete
Step #2: f792a8d67267: Pull complete
Step #2: 1d9810dc510f: Pull complete
Step #2: 1857069560bc: Pull complete
Step #2: 78e6ceea88a6: Pull complete
Step #2: 17808c78ea57: Pull complete
Step #2: 8f44844313bf: Pull complete
Step #2: 68ad45c242a0: Pull complete
Step #2: fcf83fd73d90: Pull complete
Step #2: f7e1d363b903: Pull complete
Step #2: db117322f9a6: Pull complete
Step #2: 107df8cebbb8: Pull complete
Step #2: 1cc01a448cf6: Pull complete
Step #2: d21f6d830ee4: Pull complete
Step #2: fc42a3e733c1: Pull complete
Step #2: dc1d9449fa6d: Pull complete
Step #2: 1a868119fc13: Pull complete
Step #2: 9f6036440dbe: Pull complete
Step #2: 781f18f06da3: Pull complete
Step #2: eed24b20f933: Pull complete
Step #2: 796c70780a0c: Pull complete
Step #2: Digest: sha256:9ab02f5b3c7db82a3ce7ef753b0f7894c11e2761a4100009fdf61e4e5354a728
Step #2: Status: Downloaded newer image for gcr.io/agones-images/agones-build:add8116b91
Finished Step #2
Starting Step #3 - "lint"
Step #3 - "lint": Already have image: make-docker
Step #3 - "lint": mkdir -p ~/.kube/
Step #3 - "lint": mkdir -p /workspace/build//.config/gcloud
Step #3 - "lint": docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v /workspace:/go/src/agones.dev/agones -w /go/src/agones.dev/agones  agones-build:add8116b91 bash -c \
Step #3 - "lint": 	"golangci-lint run ./examples/... && golangci-lint run --deadline 15m ./..."
Step #3 - "lint": test/e2e/framework/framework.go:122: File is not `goimports`-ed (goimports)
Step #3 - "lint": 	err := wait.PollImmediate(2*time.Second, 5 * time.Minute, func() (bool, error) {
Step #3 - "lint": Makefile:191: recipe for target 'lint' failed
Step #3 - "lint": make: *** [lint] Error 1
Finished Step #3 - "lint"
ERROR
ERROR: build step 3 "make-docker" failed: exit status 2

@markmandel
Make WaitForFleetCondition take up to 5 minutes
3eadf34 
Should fix flakiness in autoscaler tests.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: dc36aa67-a2b5-4f0d-b70f-9b0a776ab25a

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/377/head:pr_377 && git checkout pr_377
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-3eadf34

@markmandel
Copy link
Member Author

@victor-prodan 🤞 this solves the flakiness 👍

victor-prodan
victor-prodan reviewed Oct 9, 2018
View reviewed changes
test/e2e/framework/framework.go
@@ -119,7 +118,7 @@ func (f *Framework) WaitForGameServerState(gs *v1alpha1.GameServer, state v1alph

// WaitForFleetCondition waits for the Fleet to be in a specific condition
func (f *Framework) WaitForFleetCondition(flt *v1alpha1.Fleet, condition func(fleet *v1alpha1.Fleet) bool) error {
err := wait.PollImmediate(2*time.Second, 120*time.Second, func() (bool, error) {
err := wait.PollImmediate(2*time.Second, 5*time.Minute, func() (bool, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a global e2e test timeout as well? If yes, maybe it should be increased too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we're not hitting this right now, so if we start too - we can increase it. Right now it's 10 minutes, and we're not even close.

cyriltovena
cyriltovena approved these changes Oct 9, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markmandel markmandel merged commit cd0c726 into googleforgames:master Oct 9, 2018
@markmandel markmandel deleted the flaky/autoscaler branch October 9, 2018 15:47
@markmandel markmandel added this to the 0.5.0 milestone Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victor-prodan victor-prodan victor-prodan left review comments

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @cyriltovena @victor-prodan