Remove c++ sdk destructor causing linker errors #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Succeeded 👏 Build Id: 64bc397d-578b-4a71-90e5-01c7199b7b10 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
markmandel
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the destructor declaration, because it had no body in the cpp file it caused linker errors. I removed the declaration from the header file so that the compiler will generate a default dtor. I also updated the cpp example to
deletethe sdk pointer in the end. That way it will act as a "unit-test" if the same thing happens in the future.fixes #366