Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ReadTimeout for e2e tests, otherwise this can hang forever. #359

Merged
merged 1 commit into from
Sep 20, 2018

Conversation

markmandel
Copy link
Member

No description provided.

@markmandel markmandel added kind/bug These are bugs. area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Sep 20, 2018
@markmandel markmandel added this to the 0.5.0 milestone Sep 20, 2018
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b055484e-7d87-4a8e-8209-f1ca95033993

Build Logs
starting build "b055484e-7d87-4a8e-8209-f1ca95033993"

FETCHSOURCE
Initialized empty Git repository in /workspace/.git/
From https://source.developers.google.com/p/agones-images/r/agones
 * branch            548f0855cbaff87c38a76ef9cd06445a84bfdcb4 -> FETCH_HEAD
HEAD is now at 548f085 Add ReadTimeout for e2e tests, otherwise this can hang forever.
BUILD
Starting Step #0
Step #0: Already have image (with digest): ubuntu
Finished Step #0
Starting Step #1
Step #1: Already have image (with digest): gcr.io/cloud-builders/docker
Step #1: Sending build context to Docker daemon  107.3MB

Step #1: Step 1/3 : FROM gcr.io/cloud-builders/docker
Step #1:  ---> 1f5b51e1aa12
Step #1: Step 2/3 : RUN apt-get install make
Step #1:  ---> Running in 10a5e96114fc
Step #1: Reading package lists...
Step #1: Building dependency tree...
Step #1: Reading state information...
Step #1: make is already the newest version (4.1-6).
Step #1: 0 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
Step #1: Removing intermediate container 10a5e96114fc
Step #1:  ---> aa2ceaa387f6
Step #1: Step 3/3 : ENTRYPOINT ["/usr/bin/make"]
Step #1:  ---> Running in 3f9a30e9500d
Step #1: Removing intermediate container 3f9a30e9500d
Step #1:  ---> 9d1a8aae3644
Step #1: Successfully built 9d1a8aae3644
Step #1: Successfully tagged make-docker:latest
Finished Step #1
Starting Step #2
Step #2: Already have image: make-docker
Step #2: docker pull gcr.io/agones-images/agones-build:add8116b91 && docker tag gcr.io/agones-images/agones-build:add8116b91 agones-build:add8116b91
Step #2: add8116b91: Pulling from agones-images/agones-build
Step #2: cc1a78bfd46b: Pulling fs layer
Step #2: 65ec5fb8fee4: Pulling fs layer
Step #2: f792a8d67267: Pulling fs layer
Step #2: 1d9810dc510f: Pulling fs layer
Step #2: 1857069560bc: Pulling fs layer
Step #2: 78e6ceea88a6: Pulling fs layer
Step #2: 17808c78ea57: Pulling fs layer
Step #2: 8f44844313bf: Pulling fs layer
Step #2: 68ad45c242a0: Pulling fs layer
Step #2: fcf83fd73d90: Pulling fs layer
Step #2: f7e1d363b903: Pulling fs layer
Step #2: db117322f9a6: Pulling fs layer
Step #2: 107df8cebbb8: Pulling fs layer
Step #2: 1cc01a448cf6: Pulling fs layer
Step #2: d21f6d830ee4: Pulling fs layer
Step #2: fc42a3e733c1: Pulling fs layer
Step #2: dc1d9449fa6d: Pulling fs layer
Step #2: 1a868119fc13: Pulling fs layer
Step #2: 9f6036440dbe: Pulling fs layer
Step #2: 781f18f06da3: Pulling fs layer
Step #2: eed24b20f933: Pulling fs layer
Step #2: 796c70780a0c: Pulling fs layer
Step #2: 17808c78ea57: Waiting
Step #2: f7e1d363b903: Waiting
Step #2: 8f44844313bf: Waiting
Step #2: 68ad45c242a0: Waiting
Step #2: db117322f9a6: Waiting
Step #2: 107df8cebbb8: Waiting
Step #2: fcf83fd73d90: Waiting
Step #2: 1cc01a448cf6: Waiting
Step #2: 9f6036440dbe: Waiting
Step #2: d21f6d830ee4: Waiting
Step #2: 781f18f06da3: Waiting
Step #2: fc42a3e733c1: Waiting
Step #2: eed24b20f933: Waiting
Step #2: dc1d9449fa6d: Waiting
Step #2: 796c70780a0c: Waiting
Step #2: 1a868119fc13: Waiting
Step #2: 1d9810dc510f: Waiting
Step #2: 1857069560bc: Waiting
Step #2: 78e6ceea88a6: Waiting
Step #2: cc1a78bfd46b: Download complete
Step #2: 1d9810dc510f: Verifying Checksum
Step #2: 1d9810dc510f: Download complete
Step #2: 65ec5fb8fee4: Verifying Checksum
Step #2: 65ec5fb8fee4: Download complete
Step #2: 1857069560bc: Verifying Checksum
Step #2: 1857069560bc: Download complete
Step #2: 78e6ceea88a6: Verifying Checksum
Step #2: 78e6ceea88a6: Download complete
Step #2: 17808c78ea57: Verifying Checksum
Step #2: 17808c78ea57: Download complete
Step #2: 68ad45c242a0: Download complete
Step #2: 8f44844313bf: Verifying Checksum
Step #2: 8f44844313bf: Download complete
Step #2: f7e1d363b903: Verifying Checksum
Step #2: f7e1d363b903: Download complete
Step #2: fcf83fd73d90: Verifying Checksum
Step #2: fcf83fd73d90: Download complete
Step #2: cc1a78bfd46b: Pull complete
Step #2: db117322f9a6: Verifying Checksum
Step #2: db117322f9a6: Download complete
Step #2: 1cc01a448cf6: Verifying Checksum
Step #2: 1cc01a448cf6: Download complete
Step #2: 107df8cebbb8: Verifying Checksum
Step #2: 107df8cebbb8: Download complete
Step #2: d21f6d830ee4: Verifying Checksum
Step #2: d21f6d830ee4: Download complete
Step #2: f792a8d67267: Verifying Checksum
Step #2: f792a8d67267: Download complete
Step #2: 1a868119fc13: Verifying Checksum
Step #2: 1a868119fc13: Download complete
Step #2: 9f6036440dbe: Verifying Checksum
Step #2: 9f6036440dbe: Download complete
Step #2: 781f18f06da3: Verifying Checksum
Step #2: 781f18f06da3: Download complete
Step #2: eed24b20f933: Download complete
Step #2: dc1d9449fa6d: Download complete
Step #2: 796c70780a0c: Verifying Checksum
Step #2: 796c70780a0c: Download complete
Step #2: fc42a3e733c1: Verifying Checksum
Step #2: 65ec5fb8fee4: Pull complete
Step #2: f792a8d67267: Pull complete
Step #2: 1d9810dc510f: Pull complete
Step #2: 1857069560bc: Pull complete
Step #2: 78e6ceea88a6: Pull complete
Step #2: 17808c78ea57: Pull complete
Step #2: 8f44844313bf: Pull complete
Step #2: 68ad45c242a0: Pull complete
Step #2: fcf83fd73d90: Pull complete
Step #2: f7e1d363b903: Pull complete
Step #2: db117322f9a6: Pull complete
Step #2: 107df8cebbb8: Pull complete
Step #2: 1cc01a448cf6: Pull complete
Step #2: d21f6d830ee4: Pull complete
Step #2: fc42a3e733c1: Pull complete
Step #2: dc1d9449fa6d: Pull complete
Step #2: 1a868119fc13: Pull complete
Step #2: 9f6036440dbe: Pull complete
Step #2: 781f18f06da3: Pull complete
Step #2: eed24b20f933: Pull complete
Step #2: 796c70780a0c: Pull complete
Step #2: Digest: sha256:9ab02f5b3c7db82a3ce7ef753b0f7894c11e2761a4100009fdf61e4e5354a728
Step #2: Status: Downloaded newer image for gcr.io/agones-images/agones-build:add8116b91
Finished Step #2
Starting Step #3 - "lint"
Step #3 - "lint": Already have image: make-docker
Step #3 - "lint": mkdir -p ~/.kube
Step #3 - "lint": mkdir -p /workspace/build//.config/gcloud
Step #3 - "lint": docker run --rm -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube:/root/.kube -v /workspace:/go/src/agones.dev/agones -w /go/src/agones.dev/agones  agones-build:add8116b91 bash -c \
Step #3 - "lint": 	"golangci-lint run ./examples/... && golangci-lint run --deadline 15m ./..."
Step #3 - "lint": test/e2e/framework/framework.go:212:22: Error return value of `conn.SetReadDeadline` is not checked (errcheck)
Step #3 - "lint": 	conn.SetReadDeadline(time.Now().Add(30 * time.Second))
Step #3 - "lint": 	                    ^
Step #3 - "lint": make: *** [lint] Error 1
Step #3 - "lint": Makefile:157: recipe for target 'lint' failed
Finished Step #3 - "lint"
ERROR
ERROR: build step 3 "make-docker" failed: exit status 2

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1d1e69b6-dbe8-4703-bb69-05c0ab1a86a3

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/359/head:pr_359 && git checkout pr_359
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.5.0-b21b95a

@markmandel markmandel merged commit 4b6aa88 into googleforgames:master Sep 20, 2018
@markmandel markmandel deleted the build/read-timeout branch September 20, 2018 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/bug These are bugs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants