Ability to pass GameServer yaml/json to local sdk server
#328
Conversation
markmandel
added
kind/feature
|
/cc @victor-prodan - sneaking this one in, as I know you wanted it 😄 |
|
Build Succeeded 👏 Build Id: 0bfb8096-26dd-4630-b554-5bd8bda4c8db The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
|
@markmandel I could not find any way to reply to my 2 threads above and I'm new at github - did you close them by any chance? About the 4096 constant, the problem I have is that it's completely magic;; when I read this code I have no idea why it's 4096 and not 128 or 16384. "Because kubernetes does it" is just another magic layer :) In this case, I believe that the writer of the function should have also exposed a default buffer size as a constant. Because that's missing, I think you could at least add a more specific reference and explanation. Just my opinion :) About the allocation emulation yes you're right, we have #314 for it. I was mostly curious because I am new at go and didn't know if maybe I missed something. Anyway, good idea about setting it directly in 'allocated' state 👍 |
markmandel
force-pushed
the
feature/local-file
branch
from
e784314
to
8e1141a
Compare
|
@victor-prodan the comments you made are tied to the commit, so you have to go back to the commit to reply 😄 github shenanigans. Totally fair call about 4096 (you also made me laugh out loud 🤣 )! At the very least, it should be a much clearer explanation of what that value is! I have made that change now.
I agree on that point as well! |
|
Build Succeeded 👏 Build Id: 2b1126eb-fcab-4798-929e-867e617715b6 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
To be able to work locally, you need to be able to specify your local `GameServer` configuration, as it likely will have application specific configuration in it -- or maybe you want to specify what state it's in. This commit allow you to specify the local resource as either yaml/json through a `-f` or `--file` flag. Closes googleforgames#296
markmandel
force-pushed
the
feature/local-file
branch
from
8e1141a
to
a486366
Compare
|
Build Succeeded 👏 Build Id: 6820c3b3-efa4-4cb7-8d39-6407bd4c98c8 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
To be able to work locally, you need to be able to specify your local
GameServerconfiguration, as it likely will have application specific configuration in it -- or maybe you want to specify what state it's in.This commit allow you to specify the local resource as either yaml/json through a
-for--fileflag.Closes #296